-
Notifications
You must be signed in to change notification settings - Fork 37
Refactor estimate_truncation to use S3 class pattern #1221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
82 commits
Select commit
Hold shift + click to select a range
77cc3f5
Simplify estimate_truncation return structure
sbfnk 1641101
Add get_samples.estimate_truncation method
sbfnk 20f45dd
Add summary.estimate_truncation method
sbfnk 0518970
Update estimate_truncation tests for new structure
sbfnk 9574383
Update documentation for estimate_truncation changes
sbfnk 3bdfe36
Add NEWS entry for estimate_truncation changes
sbfnk fb8a172
Merge main into branch
sbfnk 1d7f587
Add get_dist() generic and estimate_truncation method
sbfnk 9a4fe40
Remove dist from return, use get_dist() accessor
sbfnk 6d9a516
Update summary.estimate_truncation to use get_dist()
sbfnk 04b1143
Update tests to use get_dist() accessor
sbfnk 0fd9e90
Update NEWS for get_dist() accessor
sbfnk a948b41
Rename get_dist() to get_delay() for consistency
sbfnk e142e65
Merge branch 'main' into refactor/estimate-truncation-s3
sbfnk 8f4e7f8
Fix backward compat accessors to return values and use I()
sbfnk b95bc67
Update vignette to use get_delay() instead of $dist
sbfnk 0b8684d
Consolidate NEWS.md entry for get_delay()
sbfnk aa6b449
Clarify get_delay() extracts truncation delay distribution
sbfnk 3df3e60
Merge remote-tracking branch 'origin/refactor/estimate-truncation-s3'…
sbfnk b69669c
Add regression tests for deprecated accessor return values
sbfnk 18d3f18
Use as.data.frame() in snapshots to avoid data.table print format issues
sbfnk 08cc931
Merge branch 'main' into refactor/estimate-truncation-s3
sbfnk f89e251
Replace get_delay() with get_delays() returning named list
sbfnk 086ff37
Update documentation
epiforecasts-workflows[bot] a66ec9f
Revert "Use as.data.frame() in snapshots to avoid data.table print fo…
sbfnk 12ace0a
Add test for get_delays() fixed parameter values
sbfnk fb73240
Remove internal element access from estimate_truncation example
sbfnk dc5ceeb
Remove extra components from stan_data in estimate_truncation
sbfnk 1ad9b07
Refactor get_delays and summary methods
sbfnk 3602868
Use get_predictions() in plot.estimate_truncation
sbfnk 98f7636
Add print method for summary and improve deprecated accessors
sbfnk 246f861
Fix line length lint issues in summarise.R
sbfnk f98dd05
Update estimate_truncation example to reflect summary changes
sbfnk 44d427a
Rename obs to preds in plot.estimate_truncation for clarity
sbfnk b442658
Use x$observations for raw data and get_predictions for CrIs in plot
sbfnk 2f40b7f
Refactor [[.estimate_truncation to delegate to $ method
sbfnk 8dba8ff
Compute predictions on demand from samples
sbfnk d527a59
Remove last_confirm from get_predictions output
sbfnk 65afc2c
get_predictions returns only predictions, no observations
sbfnk 506bfc8
Add epinowfit superclass to estimate_truncation
sbfnk dcc27d3
Simplify get_samples and fix dt variable naming
sbfnk c23863f
Fix line length and indentation lint issues
sbfnk 99620bc
Consolidate get_delays methods into get_delays.epinowfit
sbfnk 327cbaa
Refactor reconstruct_delay into smaller helper functions
sbfnk 72cd0dc
Update documentation
epiforecasts-workflows[bot] 95f5621
Add get_observations generic and document helpers
sbfnk a60b8a4
Merge remote-tracking branch 'origin/refactor/estimate-truncation-s3'…
sbfnk bf297c2
Add full documentation for internal helper functions
sbfnk 6950fb6
Rename dist_types() and fix get_samples consistency
sbfnk e49ce6a
Fix test to use correct parameter names after get_samples change
sbfnk fad9fb7
Refactor extract_delays/parameters to take args separately
sbfnk bdfdff6
Update documentation
epiforecasts-workflows[bot] cb341ff
Make args required in extract_delays and extract_parameters
sbfnk aaa1a06
Merge branch 'refactor/estimate-truncation-s3' of github.com:epiforec…
sbfnk 2bad2bf
Update documentation
epiforecasts-workflows[bot] d60dfbf
Fix extract_* calls after making args required
sbfnk 64bc1d9
Merge branch 'refactor/estimate-truncation-s3' of github.com:epiforec…
sbfnk 2fbb304
Address reviewer nitpicks for code clarity
sbfnk 6d240d7
Address reviewer nitpicks for robustness
sbfnk f4910c9
Remove get_observations in favour of direct access
sbfnk fce855a
Fix stray newline in test comment and add issue reference
sbfnk 8fec943
Fix delay parameter naming with mixed parametric/nonparametric delays…
sbfnk 2105154
Update documentation
epiforecasts-workflows[bot] 4bc0867
Refactor extract_delays to reduce cyclomatic complexity
sbfnk bdbeddd
Update documentation
epiforecasts-workflows[bot] e3abba4
Add unit tests for build_delay_name_lookup
sbfnk 75df2a7
Simplify parameter recovery test now that bug #1236 is fixed
sbfnk 5132032
Simplify get_delays.estimate_truncation to use reconstruct_delay
sbfnk 38a9a60
Extract prepare_truncation_obs helper function
sbfnk 67d10e3
Fix deprecated accessor methods returning NULL
sbfnk 6939b15
Add tests for estimate_truncation data processing and correctness
sbfnk 6e0e0c4
Document get_predictions for estimate_truncation in NEWS
sbfnk b87e930
Merge remote-tracking branch 'origin/refactor/estimate-truncation-s3'…
sbfnk 8b2e654
Update documentation
epiforecasts-workflows[bot] a6003a9
Fix flaky estimate_truncation tests
sbfnk 53dd219
Merge remote-tracking branch 'origin/refactor/estimate-truncation-s3'…
sbfnk d74d860
Add get_delay() convenience function
sbfnk 776fea1
Remove redundant get_delays.estimate_truncation method
sbfnk 946a9bc
Add parameter recovery integration test for estimate_truncation
sbfnk 06fee49
Fix documentation reference to removed method
sbfnk 14f6146
Extract merge_predictions_obs helper and use get_delay in examples
sbfnk e89e1e5
Rename merge_predictions_obs to merge_truncation_predictions_obs
sbfnk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.