fix: passing the adapter_opts properly#431
Merged
sleipnir merged 5 commits intoelixir-grpc:masterfrom Aug 8, 2025
Merged
Conversation
sleipnir
requested changes
Aug 4, 2025
Collaborator
sleipnir
left a comment
sleipnir
left a comment
There was a problem hiding this comment.
Just a few minor comments and questions
Collaborator
|
@XinGuanTubi please check the formatting |
Contributor
Author
|
@sleipnir I've formatted the file |
Collaborator
Tks! |
Collaborator
|
Hi @XinGuanTubi some tests failed! https://github.com/elixir-grpc/grpc/actions/runs/16768441575/job/47612192934 |
Contributor
Author
|
@sleipnir I've fixed the tests that have |
Collaborator
|
@XinGuanTubi Thank you for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
adapter_optskeyword list encapsulates the :ip and :net options.