Skip to content

The option adapter_opts in Server doesn't actually pass to the adapter #428

@xinguanz

Description

@xinguanz

Describe the bug
The commit in version v0.10.2 tried to fix the issue described in #421. It added adapter_opts as a valid keyword for Server, and passed it to the adapter, say cowboy adapter.

However, the adapter_opts in cowboy adapter is popped out from opts and is not involved in the subsequent initialization steps.

This will result in all customized opts in Server become invalid for any version later than 0.9.

To Reproduce
Use this as server opts

opts = [
   ...,
   adapter_opts: [initial_stream_window_size: 42]
]

Expected behavior
The initial_stream_window_size in adapter_opts takes part in the initialization process.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions