updated to ZenohUTransport and updated copyright notices #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PLeVasseur
reviewed
May 5, 2025
Contributor
PLeVasseur
left a comment
PLeVasseur
left a comment
There was a problem hiding this comment.
Thanks @MaximilianToe!
In lieu of there being integration tests which show that these can talk to one-another could I ask for your help in making a simple table showing that these communicated in your local testing?
e.g.
| Example | Comms flowed? |
|---|---|
| PubSub | ✅ or ❌ |
| RPC | ✅ or ❌ |
| @@ -1,25 +1,14 @@ | |||
| # Copyright (c) 2024 General Motors GTO LLC | |||
| # SPDX-FileCopyrightText: 2025 Contributors to the Eclipse Foundation | |||
| @@ -1,208 +0,0 @@ | |||
| // SPDX-FileCopyrightText: 2024 Contributors to the Eclipse Foundation | |||
Contributor
Author
Example Comms flowed? RPC: |
Contributor
|
Thanks @MaximilianToe for documenting the examples working! |
This was referenced May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the second part of the update to ZenohUTransport and does the following two things: