Make result set getColumn by name case insensitive. Add test for same.#43
Make result set getColumn by name case insensitive. Add test for same.#43jghoman wants to merge 1 commit intoduckdb:mainfrom
Conversation
…, along with tablename.
Mause
left a comment
Mause
left a comment
There was a problem hiding this comment.
Looks great!
While you're at it, would you be able to fix the other findColumn in the other class?
|
Hi @Mause, since i run into this bug: which other class did you mean? Or are there other reasons it won't get merged? |
This change brings in the duckdb#43 PR with additional changes to the `Array` result set requested by the reviewer in duckdb#43. For the `Array` result set the column names `INDEX` and `VALUE` are taken from the implementation in Postgres' `pgjdbc` driver. Testing: test from duckdb#43 is included, test for `Array` result set is enhanced with additional checks. Fixes: duckdb#40 Co-authored-by: jghoman <jghoman@gmail.com>
|
Thanks for the PR! I've included it as-is into #185 also adding there the requested changes to the I wonder if you would like to take a look at the changes to DuckDBArrayResultSet (as the original author of this bit)? The changes there are mostly mechanical, but one change of |
|
The changes from this PR were included into #185 PR, closing this PR as superseded. |
This change brings in the duckdb#43 PR with additional changes to the `Array` result set requested by the reviewer in duckdb#43. For the `Array` result set the column names `INDEX` and `VALUE` are taken from the implementation in Postgres' `pgjdbc` driver. Testing: test from duckdb#43 is included, test for `Array` result set is enhanced with additional checks. Fixes: duckdb#40 Co-authored-by: jghoman <jghoman@gmail.com>
4 participants
Fixes #40 . Adds unit test both for column names from resultset as well as tablename itself, since we're already there.
This uses
equalsIgnoreCaserather than the previous `contentEquals,' which is ever so slightly different (String to String versus String to CharSequence/String/StringBuffer, respectively), but I think that shouldn't make a difference in these use cases.