Make ResultSet getters case insensitive#185
Merged
Mytherin merged 1 commit intoduckdb:mainfrom Apr 8, 2025
Merged
Conversation
elefeint
approved these changes
Apr 4, 2025
Contributor
elefeint
left a comment
elefeint
left a comment
There was a problem hiding this comment.
Thank you! I am pretty sure the original getInt() was a mistake.
This change brings in the duckdb#43 PR with additional changes to the `Array` result set requested by the reviewer in duckdb#43. For the `Array` result set the column names `INDEX` and `VALUE` are taken from the implementation in Postgres' `pgjdbc` driver. Testing: test from duckdb#43 is included, test for `Array` result set is enhanced with additional checks. Fixes: duckdb#40 Co-authored-by: jghoman <jghoman@gmail.com>
staticlibs
force-pushed
the
result_set_ignore_case
branch
from
1c6ee5a to
e61b89c
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change brings in the #43 PR with additional changes to the
Arrayresult set requested by the reviewer in #43.For the
Arrayresult set the column namesINDEXandVALUEare taken from the implementation in Postgres' pgjdbc driver.Testing: test from #43 is included, test for
Arrayresult set is enhanced with additional checks.Fixes: #40