Merged
Conversation
Collaborator
Author
|
Just for the record, the compliance/TCK test suite failure is caused by the outdated CMake min version declared in the test runner, I've submitted the PR to fix that. |
staticlibs
force-pushed
the
param_metadata
branch
from
3dcfe85 to
cad7ab0
Compare
This PR brings in the change that was contributed earlier by `eramitmittal` in duckdb#114 but was not merged. That change is rebased onto the latest `main`with minimal adjustetments. Testing: in addition to the `DECIMAL` test from original PR more tests are added to cover all other column types. Fixes: duckdb#121 Fixes: duckdb#41 Co-authored-by: eramitmittal <amit.mittal.github@gmail.com>
staticlibs
force-pushed
the
param_metadata
branch
from
cad7ab0 to
7596fd5
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings in the change that was contributed earlier by
eramitmittalin #114 but was not merged. That change is rebased onto the latestmainwith minimal adjustetments.Testing: in addition to the
DECIMALtest from original PR more tests are added to cover all other column types.Fixes: #121
Fixes: #41