Adding fuller implementation of ParameterMetadata#114
Adding fuller implementation of ParameterMetadata#114eramitmittal wants to merge 6 commits intoduckdb:mainfrom
Conversation
|
hi, any update on this? |
|
hi @Mause, can you please review and merge? |
|
The format_check failure is strange because the failing file 'DuckDBDatabaseMetaData.java' is not even part of my commit |
|
@Mause can this be merged please if there are no issues? |
|
Any update on this? |
|
thanks! |
This PR brings in the change that was contributed earlier by `eramitmittal` in duckdb#114 but was not merged. That change is rebased onto the latest `main`with minimal adjustetments. Testing: in addition to the `DECIMAL` test from original PR more tests are added to cover all other column types. Fixes: duckdb#121 Co-authored-by: eramitmittal
|
Thanks for this implementation! I took the liberty to re-submit the updated version of this PR in #181 (referencing you in the commit message). Please let me know, if instead you would like to update this PR yourself (I then will close #181). |
hi, this is fine. thanks |
This PR brings in the change that was contributed earlier by `eramitmittal` in duckdb#114 but was not merged. That change is rebased onto the latest `main`with minimal adjustetments. Testing: in addition to the `DECIMAL` test from original PR more tests are added to cover all other column types. Fixes: duckdb#121 Co-authored-by: eramitmittal <amit.mittal.github@gmail.com>
|
Changes from this PR were included into #181 PR, closing this one as superseded. |
This PR brings in the change that was contributed earlier by `eramitmittal` in duckdb#114 but was not merged. That change is rebased onto the latest `main`with minimal adjustetments. Testing: in addition to the `DECIMAL` test from original PR more tests are added to cover all other column types. Fixes: duckdb#121 Fixes: duckdb#41 Co-authored-by: eramitmittal <amit.mittal.github@gmail.com>
3 participants
Fixes #121
On the lines of pre-existing implementation of corresponding methods for columns in ResultSetMetaData, adding ParameterMetadata implementations for