34141 feedback content drive #34456
Merged
34141 feedback content drive #34456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements feedback-driven improvements to the Content Drive feature, focusing on CSS standardization, test robustness, and template modernization.
Changes:
- Corrected PrimeNG CSS selector from incorrect
p-tree-nodeto the standardp-treenode - Standardized Tailwind CSS classes using numeric shorthand notation and proper CSS variable syntax
- Enhanced test coverage with explicit null checks, MutationObserver mocking, and removed unused imports
- Modernized templates using Angular's
@ifdirective instead of CSS class-based visibility toggling - Fixed SVG asset paths to use proper relative paths
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| dot-tree-folder.component.scss | Corrected PrimeNG tree node selector from p-tree-node to p-treenode (proper PrimeNG v21 class name) |
| dot-folder-list-view.component.html | Simplified Tailwind class from max-w-[400px] to max-w-100 for consistency |
| test-setup.ts | Added MutationObserver mock to support PrimeNG components in tests |
| withSidebar.spec.ts | Enhanced test with explicit null check and error throwing for better type safety |
| dot-content-drive-shell.component.html | Simplified width classes from bracket notation to numeric shorthand (w-66) |
| dot-content-drive-toolbar.component.spec.ts | Removed unused By import and updated test to check for null instead of invisible class |
| dot-content-drive-toolbar.component.html | Modernized to use @if directive for conditional rendering instead of CSS visibility classes |
| dot-content-drive-tree-toggler.component.html | Fixed SVG path from /assets/ to ./assets/ for proper relative path resolution |
| dot-content-drive-content-type-field.component.html | Standardized CSS variable syntax to text-(--gray-500) format |
Legal RiskThe following dependencies were released under a license that RecommendationWhile merging is not directly blocked, it's best to pause and consider what it means to use this license before continuing. If you are unsure, reach out to your security team or Semgrep admin to address this issue. GPL-2.0 MPL-2.0
|
hmoreras
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses several UI inconsistencies and layout issues within the Content Drive portlet to ensure it aligns with the design specifications. The changes focus on the tree panel navigation, command bar alignment, and general visual polish.
Changes
1. Tree Panel Improvements
folder-opento provide better visual feedback for the root container.2. Command Bar Adjustments
3. Visual Polish
Verification Plan
DEMO:
Screen.Recording.2026-01-30.at.11.08.12.AM.mov
This PR fixes: #34141