chore: Refactor ADEX request visualization to use UID

dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataexchange/aggregate/SourceRequest.java

@@ -38,6 +38,7 @@
 import lombok.Setter;
 import lombok.experimental.Accessors;
 import org.hisp.dhis.analytics.AggregationType;
+import org.hisp.dhis.common.UID;
 
 @Getter
 @Setter
@@ -48,7 +49,7 @@ public class SourceRequest implements Serializable {
   @JsonProperty private String name;
 
   /** Optional UID reference to a visualization. */
-  @JsonProperty private String visualization;
+  @JsonProperty private UID visualization;
 
   /** Data dimension item identifiers. */
   @JsonProperty private List<String> dx = new ArrayList<>();

dhis-2/dhis-services/dhis-service-dxf2/src/main/java/org/hisp/dhis/dxf2/metadata/objectbundle/hooks/AggregateDataExchangeObjectBundleHook.java

@@ -36,7 +36,6 @@
 import java.util.function.Consumer;
 import lombok.RequiredArgsConstructor;
 import org.apache.commons.lang3.StringUtils;
-import org.hisp.dhis.common.CodeGenerator;
 import org.hisp.dhis.dataexchange.aggregate.AggregateDataExchange;
 import org.hisp.dhis.dataexchange.aggregate.Api;
 import org.hisp.dhis.dataexchange.aggregate.SourceRequest;
@@ -109,16 +108,6 @@ private void validateSource(AggregateDataExchange exchange, Consumer<ErrorReport
                 request.getName().length()));
       }
 
-      if (request.getVisualization() != null
-          && !CodeGenerator.isValidUid(request.getVisualization())) {
-        addReports.accept(
-            new ErrorReport(
-                AggregateDataExchange.class,
-                ErrorCode.E4014,
-                "source.visualization",
-                request.getVisualization()));
-      }
-
       if (isEmpty(request.getDx()) || isEmpty(request.getPe()) || isEmpty(request.getOu())) {
         addReports.accept(new ErrorReport(AggregateDataExchange.class, ErrorCode.E6303));
       }

dhis-2/dhis-services/dhis-service-dxf2/src/test/java/org/hisp/dhis/dxf2/metadata/objectbundle/hooks/AggregateDataExchangeObjectBundleHookTest.java

@@ -103,14 +103,6 @@ void testSourceRequestNameTooLong() {
     assertErrorCode(ErrorCode.E4001, objectBundleHook.validate(exchange, objectBundle));
   }
 
-  @Test
-  void testSourceRequestVisualizationInvalidUid() {
-    AggregateDataExchange exchange = getAggregateDataExchange('A');
-    exchange.getSource().getRequests().get(0).setVisualization("1nvalidUid");
-
-    assertErrorCode(ErrorCode.E4014, objectBundleHook.validate(exchange, objectBundle));
-  }
-
   @Test
   void testMissingSourceDxItems() {
     AggregateDataExchange exchange = getAggregateDataExchange('A');

dhis-2/dhis-support/dhis-support-test/src/main/java/org/hisp/dhis/test/TestBase.java

@@ -89,6 +89,7 @@
 import org.hisp.dhis.common.IllegalQueryException;
 import org.hisp.dhis.common.OrganisationUnitDescendants;
 import org.hisp.dhis.common.OrganisationUnitSelectionMode;
+import org.hisp.dhis.common.UID;
 import org.hisp.dhis.common.UserOrgUnitType;
 import org.hisp.dhis.common.ValueType;
 import org.hisp.dhis.common.cache.CacheStrategy;
@@ -459,7 +460,7 @@ public static AggregateDataExchange getAggregateDataExchange(char uniqueCharacte
     SourceRequest sourceRequest =
         new SourceRequest()
             .setName("RequestA")
-            .setVisualization("JHKuBWP20RO")
+            .setVisualization(UID.of("JHKuBWP20RO"))
             .setDx(newArrayList("LrDpG50RAU9", "uR5HCiJhQ1w"))
             .setPe(newArrayList("202201", "202202"))
             .setOu(newArrayList("G9BuXqtNeeb", "jDgiLmYwPDm"))

dhis-2/dhis-test-web-api/src/test/java/org/hisp/dhis/webapi/controller/MetadataImportExportControllerTest.java

@@ -565,6 +565,21 @@ void testPatchAggregateDataExchange() {
     assertEquals("External basic auth data exchange updated", object.getString("name").string());
   }
 
+  @Test
+  @DisplayName("Should return conflict when source request visualization is not a valid UID")
+  void testSourceRequestVisualizationInvalidUid() {
+    JsonWebMessage message =
+        assertWebMessage(
+            HttpStatus.CONFLICT,
+            POST(
+                "/metadata/",
+                "{'aggregateDataExchanges': [{'id': 'iFOyIpQciyk', 'name': 'Test exchange',"
+                    + "'source': {'requests': [{'name': 'R1', 'visualization': '1nvalidUid',"
+                    + "'dx': ['fbfJHSPpUQD'], 'pe': ['202201'], 'ou': ['ImspTQPwCqd']}]},"
+                    + "'target': {'type': 'INTERNAL'}}]}"));
+    assertTrue(message.getMessage().contains("1nvalidUid"));
+  }
+
   @Test
   @DisplayName(
       "Should return error E6305 if create a new AggregateDataExchange without authentication"

dhis-2/dhis-web-api/src/main/java/org/hisp/dhis/webapi/controller/CrudControllerAdvice.java

@@ -39,6 +39,7 @@
 import static org.hisp.dhis.dxf2.webmessage.WebMessageUtils.unauthorized;
 
 import com.fasterxml.jackson.core.JsonParseException;
+import com.fasterxml.jackson.databind.JsonMappingException;
 import com.fasterxml.jackson.databind.RuntimeJsonMappingException;
 import io.github.classgraph.ClassGraph;
 import jakarta.persistence.PersistenceException;
@@ -400,6 +401,7 @@ public WebMessage dataApprovalExceptionHandler(Exception ex) {
 
   @ExceptionHandler({
     JsonParseException.class,
+    JsonMappingException.class,
     MetadataImportException.class,
     MetadataExportException.class
   })