Skip to content

Conversation

@kyleam
Copy link
Contributor

@kyleam kyleam commented Jan 30, 2020

In 0.12.x, datalad save no longer accepts --super-datasets. In a
blind to make the example compatible with the latest DataLad, use the
--dataset=^ shortcut instead.

Note that there are other spots in the example that should be updated
for the 0.12.x release (e.g., use of datalad add). This is just a minimal
attempt to get it passing.

Re: #74 (comment)


Note: A test failure due to issue resolved by gh-74 is still expected.

In 0.12.x, `datalad save` no longer accepts --super-datasets.  In a
blind to make the example compatible with the latest DataLad, use the
--dataset=^ shortcut instead.

Note that there are other spots in the example that should be updated
for the 0.12.x (e.g., use of `datalad add`).  This is just a minimal
attempt to get it passing.

Re: datalad#74 (comment)
@kyleam
Copy link
Contributor Author

kyleam commented Jan 30, 2020

That test run looks as hoped/expected. The nipype_workshop_dataset.sh example doesn't show any failures. The builds with Python 3.6 show the .ix failure because they bring in pandas 1.0.0, while builds with an older Python do not show the .ix failure because pandas 1.0.0 requires at least Python 3.6 and thus isn't pulled in.

@mih
Copy link
Member

mih commented Feb 5, 2020

Thx!

@mih mih merged commit f11dac5 into datalad:master Feb 5, 2020
@kyleam kyleam deleted the example-save-no-S branch February 5, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants