Skip to content

MNT: bids2scidata: Use .iloc instead of deprecated .ix #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mih merged 1 commit into from
Feb 5, 2020
Merged

MNT: bids2scidata: Use .iloc instead of deprecated .ix #74

mih merged 1 commit into from
Feb 5, 2020

Conversation

@kyleam
Copy link
Contributor

@kyleam kyleam commented Aug 24, 2019

This popped up in the "DeprecationWarning -> error" run from datalad/datalad#3618: https://travis-ci.org/datalad/datalad/jobs/576041485#L1241

@kyleam kyleam mentioned this pull request Aug 24, 2019
Merged
3 tasks
@yarikoptic
Copy link
Member

yarikoptic commented Aug 25, 2019 

======================================================================
ERROR: datalad_neuroimaging.tests.test_bids2scidata.test_real_ds
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/virtualenv/python2.7.15/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/home/travis/virtualenv/python2.7.15/lib/python2.7/site-packages/datalad/tests/utils.py", line 615, in newfunc
    return t(*(arg + (filename,)), **kw)
  File "/home/travis/virtualenv/python2.7.15/lib/python2.7/site-packages/datalad/tests/utils.py", line 615, in newfunc
    return t(*(arg + (filename,)), **kw)
  File "/home/travis/build/datalad/datalad-neuroimaging/build/lib/datalad_neuroimaging/tests/test_bids2scidata.py", line 163, in test_real_ds
    ds = install(source=get_bids_dataset().path, path=path, reckless=True)
  File "/home/travis/build/datalad/datalad-neuroimaging/build/lib/datalad_neuroimaging/tests/utils.py", line 107, in get_bids_dataset
    message="DICOM conversion of {} scans".format(label))
  File "/home/travis/virtualenv/python2.7.15/lib/python2.7/site-packages/datalad/distribution/dataset.py", line 526, in apply_func
    return f(**kwargs)
  File "/home/travis/virtualenv/python2.7.15/lib/python2.7/site-packages/datalad/interface/utils.py", line 492, in eval_func
    return return_func(generator_func)(*args, **kwargs)
  File "/home/travis/virtualenv/python2.7.15/lib/python2.7/site-packages/datalad/interface/utils.py", line 480, in return_func
    results = list(results)
  File "/home/travis/virtualenv/python2.7.15/lib/python2.7/site-packages/datalad/interface/utils.py", line 429, in generator_func
    result_renderer, result_xfm, _result_filter, **_kwargs):
  File "/home/travis/virtualenv/python2.7.15/lib/python2.7/site-packages/datalad/interface/utils.py", line 522, in _process_results
    for res in results:
  File "/home/travis/virtualenv/python2.7.15/lib/python2.7/site-packages/datalad/interface/run.py", line 218, in __call__
    sidecar=sidecar):
  File "/home/travis/virtualenv/python2.7.15/lib/python2.7/site-packages/datalad/interface/run.py", line 623, in run_command
    raise exc
CommandError: CommandError: command 'heudiconv -f reproin -s 02 -c dcm2niix -o /tmp/datalad_temp_vIzfJ_/.cache/datalad/datalad_neuroimaging_srcrepo/datalad_neuroimaging/tests/data/bids/.git/stupid/structural -b -a /tmp/datalad_temp_vIzfJ_/.cache/datalad/datalad_neuroimaging_srcrepo/datalad_neuroimaging/tests/data/bids -l '' --minmeta --files /tmp/datalad_temp_vIzfJ_/.cache/datalad/datalad_neuroimaging_srcrepo/datalad_neuroimaging/tests/data/bids/sourcedata/sub-02/ses-structural/dicoms' failed with exitcode 1
Failed to run u"heudiconv -f reproin -s 02 -c dcm2niix -o /tmp/datalad_temp_vIzfJ_/.cache/datalad/datalad_neuroimaging_srcrepo/datalad_neuroimaging/tests/data/bids/.git/stupid/structural -b -a /tmp/datalad_temp_vIzfJ_/.cache/datalad/datalad_neuroimaging_srcrepo/datalad_neuroimaging/tests/data/bids -l '' --minmeta --files /tmp/datalad_temp_vIzfJ_/.cache/datalad/datalad_neuroimaging_srcrepo/datalad_neuroimaging/tests/data/bids/sourcedata/sub-02/ses-structural/dicoms" under '/tmp/datalad_temp_vIzfJ_/.cache/datalad/datalad_neuroimaging_srcrepo/datalad_neuroimaging/tests/data/bids'. Exit code=1.

and previous PR build (11 days ago though) didn't have this failure

@yarikoptic
Copy link
Member

yarikoptic commented Aug 25, 2019

restarted that PR #73 travis build to see what is failing there now

@kyleam
Copy link
Contributor Author

kyleam commented Aug 26, 2019

restarted that PR #73 travis build to see what is failing there now

test_real_ds fails in that python 2 build as well: https://travis-ci.org/datalad/datalad-neuroimaging/jobs/571411988#L1249

@kyleam
Copy link
Contributor Author

kyleam commented Jan 30, 2020

I think this should resolve the failure that @mih just noted in datalad core, so I'll rebase this and see how the tests here look.

@kyleam
Copy link
Contributor Author

kyleam commented Jan 30, 2020 •
edited
Loading

The test failures are unrelated. They're due to nipype_workshop_dataset.sh passing -S to datalad save, which isn't supported on 0.12. (edit: dealt with in gh-78)

@kyleam
MNT: bids2scidata: Use .iloc instead of deprecated .ix
6f86a91 
.ix was deprecated in pandas 0.20.0 and has been removed in the latest
release, 1.0.0.
kyleam added a commit to kyleam/datalad-neuroimaging that referenced this pull request Jan 30, 2020
@kyleam
MNT: nipype_workshop_dataset: Update save() call for DataLad 0.12
9398896 
In 0.12.x, `datalad save` no longer accepts --super-datasets.  In a
blind to make the example compatible with the latest DataLad, use the
--dataset=^ shortcut instead.

Note that there are other spots in the example that should be updated
for the 0.12.x (e.g., use of `datalad add`).  This is just a minimal
attempt to get it passing.

Re: datalad#74 (comment)
@kyleam kyleam mentioned this pull request Jan 30, 2020
Merged
@mih
Copy link
Member

mih commented Feb 5, 2020

LGTM

@mih mih merged commit e99e56f into datalad:master Feb 5, 2020
@kyleam kyleam deleted the pandas-no-ix branch February 5, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kyleam @yarikoptic @mih