Skip to content

fix: resolve hydration mismatches on pages with ReuseCard and DataserviceCard #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThibaudDauce merged 1 commit into from
Jan 26, 2026
Merged

fix: resolve hydration mismatches on pages with ReuseCard and DataserviceCard #892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/Pages/PageShow.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
v-if="'fullWidth' in blocsTypes[bloc.class]"
v-model="(workingPage.blocs[index] as any)"
:edit
:main-color="mainColor"
v-bind="bloc.class === 'LinksListBloc' ? { 'main-color': mainColor } : {}"
/>

<!-- Other blocs use container layout -->
Expand All @@ -67,7 +67,7 @@
:is="blocsTypes[bloc.class].component"
v-model="(workingPage.blocs[index] as any)"
:edit
:main-color="mainColor"
v-bind="bloc.class === 'LinksListBloc' ? { 'main-color': mainColor } : {}"
/>
</div>

Expand Down
8 changes: 4 additions & 4 deletions datagouv-components/src/components/DataserviceCard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
v-if="dataservice.organization || dataservice.owner"
class="text-gray-medium overflow-hidden flex items-center gap-1 mt-1 mb-0"
>
<p
<div
v-if="dataservice.organization"
class="text-sm block overflow-hidden mb-0 relative z-[2]"
>
Expand All @@ -81,13 +81,13 @@
v-else
:organization="dataservice.organization"
/>
</p>
<p
</div>
<div
v-else
class="text-sm mb-0 truncate"
>
{{ ownerName }}
</p>
</div>
<RiSubtractLine class="size-4 flex-none fill-gray-medium" />
<!-- This comment is only here to fix this issue https://github.com/datagouv/cdata/issues/653, it could be empty… -->
<p class="text-sm whitespace-nowrap mb-0">
Expand Down
4 changes: 2 additions & 2 deletions datagouv-components/src/components/ReuseCard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
</AppLink>
</h3>
<div class="order-3 text-sm m-0 text-gray-medium">
<p class="text-sm mb-0 flex items-center">
<div class="text-sm mb-0 flex items-center">
<span
v-if="reuse.organization"
class="relative block truncate break-all z-[2] flex-initial"
Expand All @@ -36,7 +36,7 @@
>{{ ownerName }}</span>
<RiSubtractLine class="size-4 flex-none fill-gray-medium" />
<span class="block flex-none">{{ t('publié {date}', { date: formatRelativeIfRecentDate(reuse.created_at, { dateStyle: 'medium' }) }) }}</span>
</p>
</div>
<ReuseDetails :reuse />
</div>
</div>
Expand Down
Loading