Skip to content

Conversation

@ThibaudDauce
Copy link
Contributor

@ThibaudDauce ThibaudDauce commented Jan 26, 2026

  • Fix hydration mismatches on pages using ReuseCard and DataserviceCard by replacing <p> with <div> where they contain OrganizationNameWithCertificate (which renders a <div> root)
  • Stop passing main-color to all bloc components in PageShow; only pass it to LinksListBloc, the only one that declares and uses it

Copy link
Contributor

@nicolaskempf57 nicolaskempf57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll fail the accessibility audit because we have content outside of semantic markup.

But we can continue with this PR because having a malformed HTML is also wrong

@ThibaudDauce ThibaudDauce merged commit 323d68c into main Jan 26, 2026
6 checks passed
@ThibaudDauce ThibaudDauce deleted the fix_warnings branch January 26, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants