add the fmul into the intepreter #26
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Plz refer to or directly from llvm.ir: test/neura/interpreter/interpreter.mlir
|
Collaborator
Author
|
@tancheng Hi, I have add the interpreter.mlir and the multi_ops.mlir, but I am confused how the multi_ops works |
Contributor
Sorry, I just meant have a test including both sub and mul.
You mean you don't understand something? or it doesn't work on your side? |
tancheng
reviewed
Jun 5, 2025
| @@ -29,22 +29,14 @@ | |||
| // GOLDEN: 7.0 | |||
Contributor
There was a problem hiding this comment.
May need change 7.0 to 63.0.
tancheng
reviewed
Jun 5, 2025
| %arg0 = arith.constant 9.0 : f32 | ||
| %cst = arith.constant 2.0 : f32 | ||
| %0 = arith.subf %arg0, %cst : f32 | ||
| %1 = arith.mulf %arg0, %0 : f32 |
Contributor
There was a problem hiding this comment.
You may need to provide the lowering from Arith to Neura. Currently, you only enable LLVM to Neura.
add arith to neura for fmul
Yfeng-44
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I have added the fmul for interpreter, let me know if I miss something.