Skip to content

Conversation

@pan-kot
Copy link
Member

@pan-kot pan-kot commented Jan 2, 2026

Description

Recalculates dropdown placement in autosuggest, select, and multiselect when options count increase. This ensures the best reasonable placement when options are loaded asynchronously but does not cause unnecessary position change when option list is filtered.

Rel: AWSUI-61474

How has this been tested?

  • Manual testing in the new test page
  • New integration tests

Before:

Screen.Recording.2026-01-02.at.12.21.40.mov

After:

Screen.Recording.2026-01-02.at.12.22.04.mov
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pan-kot pan-kot requested a review from a team as a code owner January 2, 2026 11:22
@pan-kot pan-kot requested review from NathanZlion and removed request for a team January 2, 2026 11:22
@pan-kot pan-kot marked this pull request as draft January 2, 2026 11:37
NathanZlion
NathanZlion previously approved these changes Jan 2, 2026
@pan-kot pan-kot force-pushed the fix-dropdown-async-load-placement branch from b6f4384 to e4d4056 Compare January 2, 2026 12:57
@pan-kot pan-kot force-pushed the fix-dropdown-async-load-placement branch from e4d4056 to 23d0d60 Compare January 2, 2026 14:15
@pan-kot pan-kot requested a review from NathanZlion January 2, 2026 14:15
@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.13%. Comparing base (73fc383) to head (2ff72d8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4147   +/-   ##
=======================================
  Coverage   97.13%   97.13%           
=======================================
  Files         873      873           
  Lines       25562    25568    +6     
  Branches     9239     9242    +3     
=======================================
+ Hits        24830    24836    +6     
  Misses        726      726           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants