Fix more typos #217
Fix more typos #217
Conversation
Matt711
force-pushed
the
bug/typos
branch
4 times, most recently
from
22738f4 to
0133749
Compare
clflushopt
left a comment
clflushopt
left a comment
There was a problem hiding this comment.
LGTM, minor question about whether it makes more sense to exclude the q_and_a directory instead of adding the typo-off rule there.
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM! a few nit comments on config. Thanks!
|
oh that was weird, I had to resolve all the conversation in order to have the merge button light up... |
Interesting, it doesn't appear to be a new feature https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches#require-conversation-resolution-before-merging |
3 participants
Contributes to #214 by running typos locally and updating the contributing guide.
Edit: My apologies for the force push. I had conflicting commits on a seperate feature branch and I was trying to clean things up.