Skip to content

feat(filtermail): Replace filtermail with rust reimplementation #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
j-g00da merged 1 commit into from
Jan 23, 2026
Merged

feat(filtermail): Replace filtermail with rust reimplementation #808

j-g00da merged 1 commit into from
Jan 23, 2026
+67 −750

Conversation

@j-g00da
Copy link
Collaborator

@j-g00da j-g00da commented Jan 15, 2026 •
edited
Loading

WIP, for testing purposes it downloads a binary I self-host and sets the logging level to debug.

@j-g00da j-g00da force-pushed the j-g00da/filtermail-rs branch from 36e8e12 to 3a8872e Compare January 15, 2026 20:11
@j-g00da j-g00da force-pushed the j-g00da/filtermail-rs branch from 3a8872e to 4511f75 Compare January 15, 2026 20:52
@j-g00da j-g00da linked an issue Jan 15, 2026 that may be closed by this pull request
Replace filtermail.py with a Rust version #804
Closed
@j-g00da j-g00da force-pushed the j-g00da/filtermail-rs branch from 4511f75 to a547b4c Compare January 16, 2026 09:10
@j-g00da j-g00da force-pushed the j-g00da/filtermail-rs branch from a547b4c to e777449 Compare January 16, 2026 11:09
@j-g00da j-g00da temporarily deployed to staging-ipv4.testrun.org January 16, 2026 11:09 — with GitHub Actions Inactive
@j-g00da j-g00da temporarily deployed to staging2.testrun.org January 16, 2026 11:09 — with GitHub Actions Inactive
j4n
j4n previously requested changes Jan 19, 2026
View reviewed changes
Copy link
Contributor

@j4n j4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me generally based on preliminary testing, two suggestions :)

@j-g00da j-g00da force-pushed the j-g00da/filtermail-rs branch from e777449 to 0dd439c Compare January 19, 2026 12:41
@j-g00da j-g00da temporarily deployed to staging-ipv4.testrun.org January 19, 2026 12:41 — with GitHub Actions Inactive
@j-g00da j-g00da temporarily deployed to staging2.testrun.org January 19, 2026 12:41 — with GitHub Actions Inactive
@j-g00da j-g00da force-pushed the j-g00da/filtermail-rs branch from 0dd439c to 17f83c2 Compare January 19, 2026 13:03
@j-g00da j-g00da temporarily deployed to staging-ipv4.testrun.org January 19, 2026 13:03 — with GitHub Actions Inactive
@j-g00da j-g00da temporarily deployed to staging2.testrun.org January 19, 2026 13:03 — with GitHub Actions Inactive
@j-g00da j-g00da force-pushed the j-g00da/filtermail-rs branch from 17f83c2 to 1f74d2a Compare January 19, 2026 13:09
@j-g00da j-g00da temporarily deployed to staging-ipv4.testrun.org January 19, 2026 13:09 — with GitHub Actions Inactive
@j-g00da j-g00da temporarily deployed to staging2.testrun.org January 19, 2026 13:09 — with GitHub Actions Inactive
@j-g00da j-g00da force-pushed the j-g00da/filtermail-rs branch from 1f74d2a to 3016cda Compare January 19, 2026 13:23
@j-g00da j-g00da temporarily deployed to staging-ipv4.testrun.org January 19, 2026 13:23 — with GitHub Actions Inactive
@j-g00da j-g00da temporarily deployed to staging2.testrun.org January 19, 2026 13:23 — with GitHub Actions Inactive
@j-g00da j-g00da force-pushed the j-g00da/filtermail-rs branch from 964b675 to b10b8da Compare January 21, 2026 16:33
@j-g00da j-g00da temporarily deployed to staging-ipv4.testrun.org January 21, 2026 16:33 — with GitHub Actions Inactive
@j-g00da j-g00da temporarily deployed to staging2.testrun.org January 21, 2026 16:33 — with GitHub Actions Inactive
@j-g00da
Copy link
Collaborator Author

j-g00da commented Jan 21, 2026

All known issues now fixed.

@j-g00da j-g00da force-pushed the j-g00da/filtermail-rs branch from b10b8da to fe97bb6 Compare January 22, 2026 14:30
link2xt
link2xt reviewed Jan 22, 2026
View reviewed changes
@j-g00da j-g00da force-pushed the j-g00da/filtermail-rs branch from fe97bb6 to e2cf147 Compare January 22, 2026 15:14
@link2xt link2xt dismissed j4n’s stale review January 22, 2026 15:15

Seems to be fixed

@j-g00da j-g00da force-pushed the j-g00da/filtermail-rs branch from e2cf147 to b5d064b Compare January 23, 2026 10:05
@j-g00da j-g00da temporarily deployed to staging-ipv4.testrun.org January 23, 2026 10:05 — with GitHub Actions Inactive
@j-g00da j-g00da force-pushed the j-g00da/filtermail-rs branch from b5d064b to dc8b4b7 Compare January 23, 2026 10:26
j4n
j4n approved these changes Jan 23, 2026
View reviewed changes
Copy link
Contributor

@j4n j4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

@link2xt
Copy link
Contributor

link2xt commented Jan 23, 2026

test_exceed_rate_limit fails again. It was fine with just the increase from 5 to 25.

@j-g00da
Copy link
Collaborator Author

j-g00da commented Jan 23, 2026

test_exceed_rate_limit fails again. It was fine with just the increase from 5 to 25.

it was fine only locally, still failing in CI, I guess I have to increase it further.

@j-g00da
feat(filtermail): Replace filtermail with rust reimplementation
79e41a6 
Signed-off-by: Jagoda Ślązak <jslazak@jslazak.com>
@j-g00da j-g00da force-pushed the j-g00da/filtermail-rs branch from dc8b4b7 to 79e41a6 Compare January 23, 2026 15:00
@j-g00da j-g00da temporarily deployed to staging2.testrun.org January 23, 2026 15:01 — with GitHub Actions Inactive
@j-g00da j-g00da temporarily deployed to staging-ipv4.testrun.org January 23, 2026 15:01 — with GitHub Actions Inactive
@j-g00da j-g00da merged commit ab3492d into main Jan 23, 2026
6 checks passed
@j-g00da j-g00da deleted the j-g00da/filtermail-rs branch January 23, 2026 15:31
@link2xt
Copy link
Contributor

link2xt commented Jan 23, 2026

Follow-up issue for the test: #821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hpk42 hpk42 hpk42 approved these changes

@j4n j4n j4n approved these changes

@link2xt link2xt link2xt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace filtermail.py with a Rust version

6 participants

@j-g00da @missytake @link2xt @hpk42 @j4n