feat: migrate from sync.Map to xsync.Map#1394
Merged
egibs merged 1 commit intochainguard-dev:mainfrom Feb 23, 2026
Merged
Conversation
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
stevebeattie
approved these changes
Feb 23, 2026
Member
stevebeattie
left a comment
stevebeattie
left a comment
There was a problem hiding this comment.
LGTM, I really like being able to be explicit about the map types.
This does mean that we change some APIs, do we need to double check users of malcontent as a library to make sure things still compile/work there?
Member
Author
We should be fine in the one place that's top of mind because we're only decoding result JSON in a way that bypasses any sync.Map usage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates from using
sync.Maptoxsync.Mapwhich is generally more performant in all cases. This also has the benefit of removing most of the tedious type checking we were doing when iterating over the original maps. I've been meaning to do this for a while but the recent focus on testing debt pushed this down the list.All of the changes test cleanly and
make refresh-sample-testdataproduces no drift.