fix: avoid deadlock in TestStringPoolRaceCondition#1395
Merged
egibs merged 2 commits intochainguard-dev:mainfrom Feb 23, 2026
Merged
fix: avoid deadlock in TestStringPoolRaceCondition#1395egibs merged 2 commits intochainguard-dev:mainfrom
egibs merged 2 commits intochainguard-dev:mainfrom
Conversation
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
stevebeattie
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #1394
This PR fixes a flake with the TestStringPoolRaceCondition test where large numbers of goroutines calling
.clear()will cause a deadlock because new calls to clear the map attempt a new resize while earlier resizes are stuck onwaitForResize:We only call this once per match processor in real usage anyway, so even the lower number of iterations is much more of a stress test than what we'd encounter during normal use.