fix signed 8- and 16-bit loads in wit-dylib bindgen#2455
Merged
dicej merged 2 commits intobytecodealliance:mainfrom Mar 5, 2026
Merged
fix signed 8- and 16-bit loads in wit-dylib bindgen#2455dicej merged 2 commits intobytecodealliance:mainfrom
dicej merged 2 commits intobytecodealliance:mainfrom
Conversation
Collaborator
Author
|
I couldn't find any existing wit-dylib tests besides |
alexcrichton
approved these changes
Mar 5, 2026
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Most tests live here, but those wouldn't work to test this actually given how this is purely ABI-related. Given that I think copying wit-dylib-smoke.wat is fine and it'd just be a manual inspection that *_s instructions show up
Collaborator
Author
Oof, sorry I missed the |
Ideally, we'd model this as a runtime test which uses WAT to avoid compiler-optimization-induced unpredictability, but that would be a lot of work, so we settle for checking that the `wit-dylib` output does in fact use signed loads when the WIT world requires them. I've verified that these tests fail without my earlier fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.