feat: Add new_wsh_sortedmulti and new_pk#949
Open
ItoroD wants to merge 2 commits intobitcoindevkit:masterfrom
Open
feat: Add new_wsh_sortedmulti and new_pk#949ItoroD wants to merge 2 commits intobitcoindevkit:masterfrom
new_wsh_sortedmulti and new_pk#949ItoroD wants to merge 2 commits intobitcoindevkit:masterfrom
Conversation
new_wsh_sortedmulti and new_pk
Collaborator
|
this is really cool @ItoroD |
9 tasks
e5c8e2f to
eb836c7
Compare
Collaborator
Author
Thanks! If this get approved, I am hoping to bring in the other similar miniscript methods that take either a list of PKs or single Pk. There are other ones that take more complex params that I can focus my attention on later once these simple ones are in. I did just these 2 in this pr just as a sort of concept and starter for the rest. |
eb836c7 to
777bc48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pr is based on my comment from #687 here.
Notes to the reviewers
In bdk-wallet we can do the following to create a 1 of 2 multisig descriptor. Thanks so miniscript helper functions
In bindings: kotlin, we do:
Current we have to concatenate a string with the keys and script type to parse the descriptor.
Much easier and safer to be able to do:
Documentation
new_wsh_sortedmulti - https://docs.rs/miniscript/12.3.5/miniscript/descriptor/enum.Descriptor.html#method.new_sh_wsh_sortedmulti
new_pk - https://docs.rs/miniscript/12.3.5/miniscript/descriptor/enum.Descriptor.html#method.new_pk
bdk_walletbitcoinuniffiOther:
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: