Skip to content

Comments

test: Add test for descriptor types.#943

Merged
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
ItoroD:descriptor-test
Feb 19, 2026
Merged

test: Add test for descriptor types.#943
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
ItoroD:descriptor-test

Conversation

@ItoroD
Copy link
Collaborator

@ItoroD ItoroD commented Jan 28, 2026

Description

This test was taken from our old Offline test that @thunderbiscuit created here. I only updated with a few additions like Check for sortedmulti. I was taking a look at issue #687 and figured these are good tests to bring back. These tests have shown some more descriptor types we can do in the bindings. I am particular curious about tr and the range of complex descriptors we are able to perform currently and those we cannot. Adding these test is a great way to start.

Notes to the reviewers

Documentation

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing
  • I've added a changelog in the next release tracking issue (see example)
  • I've linked the relevant upstream docs or specs above

Copy link
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice addition. looks like its a lot of coverage, if we want full coverage we may want to add wsh & sh_wsh?

@ItoroD
Copy link
Collaborator Author

ItoroD commented Feb 19, 2026

nice addition. looks like its a lot of coverage, if we want full coverage we may want to add wsh & sh_wsh?

Thanks for the review. I have added those now.

I am hoping we would be able to update these tests sometime later to use the actual helper methods from miniscript as in #949

@thunderbiscuit
Copy link
Member

This one needs a quick rebase and is good to go. At some point I'd be great to maybe add to the test all the descriptors that are not supported, just to make it more explicit and easier to answer questions like this one.

@thunderbiscuit
Copy link
Member

@ItoroD I think you accidentally committed your Cargo.lock file on your commit.

@ItoroD
Copy link
Collaborator Author

ItoroD commented Feb 19, 2026

@ItoroD I think you accidentally committed your Cargo.lock file on your commit.

My bad

Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0250bc8.

@thunderbiscuit thunderbiscuit merged commit 0250bc8 into bitcoindevkit:master Feb 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants