test: Add test for descriptor types.#943
Conversation
reez
left a comment
There was a problem hiding this comment.
nice addition. looks like its a lot of coverage, if we want full coverage we may want to add wsh & sh_wsh?
be20dd1 to
d163d37
Compare
Thanks for the review. I have added those now. I am hoping we would be able to update these tests sometime later to use the actual helper methods from miniscript as in #949 |
|
This one needs a quick rebase and is good to go. At some point I'd be great to maybe add to the test all the descriptors that are not supported, just to make it more explicit and easier to answer questions like this one. |
d163d37 to
909c5ca
Compare
|
@ItoroD I think you accidentally committed your Cargo.lock file on your commit. |
909c5ca to
0250bc8
Compare
My bad |
Description
This test was taken from our old Offline test that @thunderbiscuit created here. I only updated with a few additions like Check for
sortedmulti. I was taking a look at issue #687 and figured these are good tests to bring back. These tests have shown some more descriptor types we can do in the bindings. I am particular curious abouttrand the range of complex descriptors we are able to perform currently and those we cannot. Adding these test is a great way to start.Notes to the reviewers
Documentation
bdk_walletbitcoinuniffiChecklists
All Submissions:
cargo fmtandcargo clippybefore committing