Skip to content

Refactor: Replace find_by(id:) with find() for cleaner code #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
italomatos wants to merge 1 commit into from
Closed

Refactor: Replace find_by(id:) with find() for cleaner code #2288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/card.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def set_default_title
end

def handle_board_change
old_board = account.boards.find_by(id: board_id_before_last_save)
old_board = account.boards.find(board_id_before_last_save)

transaction do
update! column: nil
Expand Down
2 changes: 1 addition & 1 deletion app/models/concerns/storage/tracked.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def board_transfer?
end

def track_board_transfer
old_board = Board.find_by(id: attribute_in_database(:board_id))
old_board = Board.find(attribute_in_database(:board_id))
records = storage_transfer_records.compact
return if records.empty?

Expand Down