Refactor: Replace find_by(id:) with find() for cleaner code #2288
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace verbose find_by(id: ...) calls with the more concise find() method across Card model and Storage::Tracked concern.
italomatos
force-pushed
the
refactor/replace-find-by-id-with-find
branch
from
cd70edb to
974e096
Compare
Contributor
Author
|
Closing the PR because I saw that the behavior is correct: using find would raise an exception, and find_by without the bang returns nil. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace verbose find_by(id: ...) calls with the more concise find() method across Card model and Storage::Tracked concern.