Skip to content

Fixed the translations in the homealarm_state capability. #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frodeheg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed the translations in the homealarm_state capability. #348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 33 additions & 33 deletions assets/capability/capabilities/homealarm_state.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
{
"type": "enum",
"title": {
"en": "Home alarm state",
"nl": "Thuisalarm status",
"de": "Heim-Alarm-Status",
"fr": "Etat de l'alarme de maison",
"it": "Stato dell'allarme domestico",
"sv": "Hemlarmsstatus",
"no": "Hjemmealarmstatus",
"es": "Estado de la alarma doméstica",
"da": "Hjemmealarmstatus",
"ru": "Состояние домашней сигнализации",
"pl": "Stan alarmu domowego"
"en": "The home alarm is",
Copy link
Contributor

@WeeJeWel WeeJeWel Jun 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem right.

Copy link
Author

@frodeheg frodeheg Jun 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not qualified to assess what is the correct way to speak english, but in my view the "state" of something is a redundant word as it is implied when you refer to the actual state. That is, I believe this sounds best with:
"The home alarm is armed"
rather than
"The home alarm state is armed"

Nevertheless feel free to change it to whatever you like. I have already overridden the entire capability to improve this so I don't need this fix in the homey code at all, but I hope it can help others.

"nl": "Thuisalarm status is",
"de": "Heim-Alarm-Status ist",
"fr": "Etat de l'alarme de maison est",
"it": "Stato dell'allarme domestico è",
"sv": "Hemlarmets status är",
"no": "Boligalarmen er",
"es": "Estado de la alarma doméstica es",
"da": "Hjemmealarmstatus er",
"ru": "Состояние домашней сигнализации является",
"pl": "Stan alarmu domowego to"
},
"values": [
{
Expand Down Expand Up @@ -71,17 +71,17 @@
{
"id": "homealarm_state_changed",
"title": {
"en": "The state changed",
"nl": "De status is veranderd",
"de": "Der Status hat sich geändert",
"fr": "L'état a été modifié",
"it": "Lo stato è cambiato",
"sv": "Statusen ändrad",
"no": "Statusen ble endret",
"es": "El estado ha cambiado",
"da": "Status ændret",
"ru": "Состояние изменено",
"pl": "Zmiana stanu"
"en": "The state changed to",
"nl": "De status is veranderd in",
"de": "Der Status hat sich geändert in",
"fr": "L'état a été modifié en",
"it": "Lo stato è cambiato in",
"sv": "Statusen ändrad till",
"no": "Statusen ble endret til",
"es": "El estado ha cambiado a",
"da": "Status ændret til",
"ru": "Состояние изменено на",
"pl": "Zmiana stanu na"
},
"args": [
{
Expand Down Expand Up @@ -121,17 +121,17 @@
{
"id": "set_homealarm_state",
"title": {
"en": "Set state",
"nl": "Zet de status",
"de": "Status setzen",
"fr": "Définir l'état",
"it": "Imposta stato",
"sv": "Ställ in status",
"no": "Innstill status",
"es": "Definir estado",
"da": "Indstil status",
"ru": "Установить состояние",
"pl": "Ustaw stan"
"en": "Set state to",
"nl": "Zet de status in",
"de": "Status setzen in",
"fr": "Définir l'état en",
"it": "Imposta stato in",
"sv": "Ställ in status till",
"no": "Innstill status til",
"es": "Definir estado a",
"da": "Indstil status til",
"ru": "Установить состояние на",
"pl": "Ustaw stan na"
},
"args": [
{
Expand Down