Fixed the translations in the homealarm_state capability. #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all missing a single word
|
|
WeeJeWel
requested changes
Jun 13, 2022
| "da": "Hjemmealarmstatus", | ||
| "ru": "Состояние домашней сигнализации", | ||
| "pl": "Stan alarmu domowego" | ||
| "en": "The home alarm is", |
Author
There was a problem hiding this comment.
I am not qualified to assess what is the correct way to speak english, but in my view the "state" of something is a redundant word as it is implied when you refer to the actual state. That is, I believe this sounds best with:
"The home alarm is armed"
rather than
"The home alarm state is armed"
Nevertheless feel free to change it to whatever you like. I have already overridden the entire capability to improve this so I don't need this fix in the homey code at all, but I hope it can help others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All translations in the homealarm_state capability was missing a single word