-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-19773. [JDK17] Use JDK17 as default in precommit Docker image. #8162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
(!) A patch to the testing environment has been detected. |
|
(!) A patch to the testing environment has been detected. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
| && apt-get -q install -y --no-install-recommends $(pkg-resolver/resolve.py ubuntu:focal::arch64) \ | ||
| && apt-get clean \ | ||
| && update-java-alternatives -s java-1.8.0-openjdk-arm64 \ | ||
| && update-java-alternatives -s java-1.17.0-openjdk-amd64 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| && update-java-alternatives -s java-1.17.0-openjdk-amd64 \ | |
| && update-java-alternatives -s java-1.17.0-openjdk-arm64 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pan3793 for the careful review and the aarch64 pointers! I’ll update Dockerfile_aarch64 to apply your suggestions and push an updated commit.
| ENV PATH="${PATH}:${MAVEN_HOME}/bin" | ||
| # JAVA_HOME must be set in Maven >= 3.5.0 (MNG-6003) | ||
| ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-arm64 | ||
| ENV JAVA_HOME /usr/lib/jvm/java-17-openjdk-amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ENV JAVA_HOME /usr/lib/jvm/java-17-openjdk-amd64 | |
| ENV JAVA_HOME /usr/lib/jvm/java-17-openjdk-arm64 |
|
(!) A patch to the testing environment has been detected. |
|
🎊 +1 overall
This message was automatically generated. |
cnauroth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. Thank you @zhtttylz .
|
I committed this to trunk. Thank you @zhtttylz , @pan3793 and @slfan1989 . |
Description of PR
HADOOP-19773 [JDK17] Use JDK17 as default in precommit Docker image
The precommit Docker image currently defaults to Java 8, so CI logs for trunk PRs show JDK 8. For example, PR-8151 console output reports:
Default Java | Red Hat, Inc.-1.8.0_472-b08Update the Java configuration in the Dockerfile and switch the default Java version for the main precommit stage to JDK 17.
For code changes:
No production code changes; CI/build environment only (Dockerfile/Jenkinsfile update).