-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-19756 make std_error adopters have less friction with hadoop n… #8151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
cnauroth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why, but CI ran with the old Rocky 8 image, using Java 8:
[2025-12-30T16:12:02.717Z] Starting docker build...
[2025-12-30T16:12:03.299Z] #0 building with "default" instance using docker driver
[2025-12-30T16:12:03.299Z]
[2025-12-30T16:12:03.299Z] #1 [internal] load build definition from Dockerfile
[2025-12-30T16:12:03.299Z] #1 transferring dockerfile: 3.95kB done
[2025-12-30T16:12:03.299Z] #1 DONE 0.0s
[2025-12-30T16:12:03.299Z]
[2025-12-30T16:12:03.299Z] #2 [internal] load metadata for docker.io/library/rockylinux:8
[2025-12-30T16:12:04.710Z] #2 DONE 1.1s
[2025-12-30T16:12:04.710Z]
This is different from other recent CI runs that have switched to Ubuntu focal and Java 17:
[2025-12-24T05:31:58.502Z] Starting docker build...
[2025-12-24T05:31:58.502Z] #0 building with "default" instance using docker driver
[2025-12-24T05:31:58.502Z]
[2025-12-24T05:31:58.502Z] #1 [internal] load build definition from Dockerfile
[2025-12-24T05:31:58.502Z] #1 transferring dockerfile: 3.49kB done
[2025-12-24T05:31:58.502Z] #1 DONE 0.2s
[2025-12-24T05:31:58.502Z]
[2025-12-24T05:31:58.502Z] #2 [internal] load metadata for docker.io/library/ubuntu:focal
[2025-12-24T05:31:58.502Z] #2 DONE 1.0s
cnauroth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @edwardcapriolo . I manually kicked off another CI run here:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8151/2/
If this still fails, I'll look at manually verifying the patch myself locally.
|
💔 -1 overall
This message was automatically generated. |
|
I think #8162 should have fixed pre-commit. I triggered another manual run: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8151/3/ |
|
💔 -1 overall
This message was automatically generated. |
|
Pre-commit still didn't work. I discovered there are some remaining steps trying to use Java 8, and I filed #8166 to try to fix it. |
cnauroth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. This code had a mostly successful pre-commit run as part of testing #8166. There was a whitespace warning, which I'll clean up on commit.
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/3/artifact/out/blanks-eol.txt
|
I committed this to trunk. @edwardcapriolo , thank you! |
…ative
Description of PR
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?