This repository was archived by the owner on Jan 9, 2023. It is now read-only.
CB-14224 Default.rd.xml updates (6.0.x patch)#285
Merged
brody4hire merged 1 commit intoapache:6.0.xfrom Jul 27, 2018
Merged
Conversation
- add license text - add GitHub link
This was referenced Jul 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original issue
https://issues.apache.org/jira/browse/CB-14224
Platforms affected
Windows
What does this PR do?
Proposed
template/Properties/Default.rd.xmlupdates in 6.0.x patch release, as rebased & squashed from #284:As I said in #284 I think this is desired to satisfy the Apache RAT tool (used by
coho audit-license-headers). Alternative may be to add an exception for this file but I think it would be better to follow the standard Apache procedure if possible.What testing has been done on this change?
I verified that
coho audit-license-headers -r windowswith these changes does not show the missing license header any more.Checklist
Added automated test coverage as appropriate for this change.