Skip to content
This repository was archived by the owner on Jan 9, 2023. It is now read-only.

CB-14226 cordova-windows@6.0.1 (July 2018 patch release) on 6.0.x#287

Merged
brody4hire merged 3 commits intoapache:6.0.xfrom
brody4hire:cb-14226-6.0.1
Jul 27, 2018
Merged

CB-14226 cordova-windows@6.0.1 (July 2018 patch release) on 6.0.x#287
brody4hire merged 3 commits intoapache:6.0.xfrom
brody4hire:cb-14226-6.0.1

Conversation

@brody4hire
Copy link

@brody4hire brody4hire commented Jul 27, 2018

Platforms affected

Windows

What does this PR do?

  • Update RELEASENOTES.md with major changes for 6.0.1
  • Update JS snapshot, VERSION, and version to 6.0.1 on 6.0.x branch using the following command with updates from Improve patch release support cordova-coho#176: .\cordova-coho\coho.cmd prepare-platform-release-branch --version 6.0.1 -r windows 6.0.x

This release includes changes from the following PRs:

What testing has been done on this change?

Test checklist

  • npm outdated --depth=0 shows no red entries
  • npm audit shows 0 vulnerabilities (using npm@6.1.0 & npm@6.2.0)
  • coho audit-license-headers -r windows shows no missing license headers
  • coho check-license -r windows shows no incorrect licenses NOTE: this patch release now includes xmldom package which does not have correct SPDX expression but visual inspection of node_modules/xmldom/LICENSE shows MIT license option, which is acceptable.
  • running automatic tests from cordovamobilespec according to https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#1-plugin-tests-with-cordova-mobile-spec-project shows the following results: XXX TODO
  • npm test items succeed on AppVeyor CI

Build testing

Tested with node@4.9.1 (npm@2.15.11) on https://github.com/brodybits/cordova-sqlite-storage-starter-app:

  • Added Windows platform using the following command: cordova platform add github:brodybits/cordova-windows#cb-14226-6.0.1
  • cordova build windows --archs="x64 x86 arm" works
  • Able to run on x64 deskop Release build from VS 2017 GUI, selfTest call on cordova-sqlite-storage succeeds
  • Able to run Release build on Windows 10 mobile arm device from VS 2017 GUI, selfTest call on cordova-sqlite-storage succeeds

Successfully repeated the above sqlite-storage test with node@8.11.3, npm@5.6.0.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@brody4hire brody4hire self-assigned this Jul 27, 2018
@brody4hire brody4hire merged commit cc4733e into apache:6.0.x Jul 27, 2018
@brody4hire brody4hire changed the title CB-14226 cordova-windows@6.0.1 (July 2018 patch release) on 6.0.x - WIP CB-14226 cordova-windows@6.0.1 (July 2018 patch release) on 6.0.x Jul 27, 2018
@brody4hire brody4hire deleted the cb-14226-6.0.1 branch July 27, 2018 23:00
@brody4hire
Copy link
Author

Testing done as added to the description, changes now pushed to 6.0.x branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant