This repository was archived by the owner on Jan 9, 2023. It is now read-only.
CB-14226 cordova-windows@6.0.1 (July 2018 patch release) on 6.0.x#287
Merged
brody4hire merged 3 commits intoapache:6.0.xfrom Jul 27, 2018
Merged
CB-14226 cordova-windows@6.0.1 (July 2018 patch release) on 6.0.x#287brody4hire merged 3 commits intoapache:6.0.xfrom
brody4hire merged 3 commits intoapache:6.0.xfrom
Conversation
Author
|
Testing done as added to the description, changes now pushed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
Windows
What does this PR do?
6.0.16.0.1on6.0.xbranch using the following command with updates from Improve patch release support cordova-coho#176:.\cordova-coho\coho.cmd prepare-platform-release-branch --version 6.0.1 -r windows 6.0.xThis release includes changes from the following PRs:
npm auditissues, pinned in 6.0.x only (GH-281)error.stackincordova.js(update fromcordova-js@4.2.4) in6.0.xtemplate/Properties/Default.rd.xmlWhat testing has been done on this change?
Test checklist
npm outdated --depth=0shows no red entriesnpm auditshows 0 vulnerabilities (using npm@6.1.0 & npm@6.2.0)coho audit-license-headers -r windowsshows no missing license headerscoho check-license -r windowsshows no incorrect licenses NOTE: this patch release now includesxmldompackage which does not have correct SPDX expression but visual inspection ofnode_modules/xmldom/LICENSEshows MIT license option, which is acceptable.running automatic tests fromcordovamobilespecaccording to https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#1-plugin-tests-with-cordova-mobile-spec-project shows the following results: XXX TODOnpm testitems succeed on AppVeyor CIBuild testing
Tested with node@4.9.1 (npm@2.15.11) on https://github.com/brodybits/cordova-sqlite-storage-starter-app:
cordova platform add github:brodybits/cordova-windows#cb-14226-6.0.1cordova build windows --archs="x64 x86 arm"worksx64deskopReleasebuild from VS 2017 GUI, selfTest call on cordova-sqlite-storage succeedsReleasebuild on Windows 10 mobilearmdevice from VS 2017 GUI,selfTestcall oncordova-sqlite-storagesucceedsSuccessfully repeated the above sqlite-storage test with node@8.11.3, npm@5.6.0.
Checklist
Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.Added automated test coverage as appropriate for this change.