Skip to content

ui: fix userdata base64 encoding#7749

Merged
weizhouapache merged 3 commits intoapache:4.18from
shapeblue:fix-ui-userdata-encoding
Jul 21, 2023
Merged

ui: fix userdata base64 encoding#7749
weizhouapache merged 3 commits intoapache:4.18from
shapeblue:fix-ui-userdata-encoding

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr commented Jul 18, 2023

Description

Fixes #7748

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

userdata-encoding.mp4

Fixes apache#7748

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7749 (QA-JID-125)

@shwstppr shwstppr requested review from harikrishna-patnala and weizhouapache and removed request for weizhouapache July 18, 2023 11:10
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 18, 2023

Codecov Report

Merging #7749 (f7fc22d) into 4.18 (d575cae) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               4.18    #7749      +/-   ##
============================================
- Coverage     13.02%   13.01%   -0.01%     
  Complexity     9028     9028              
============================================
  Files          2719     2720       +1     
  Lines        256868   256992     +124     
  Branches      40051    40078      +27     
============================================
- Hits          33449    33448       -1     
- Misses       219231   219357     +126     
+ Partials       4188     4187       -1     

see 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Member

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, did not test it.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@shwstppr shwstppr marked this pull request as ready for review July 20, 2023 09:44
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7749 (QA-JID-128)

@yadvr yadvr added this to the 4.18.1.0 milestone Jul 21, 2023
@weizhouapache
Copy link
Copy Markdown
Member

code lgtm
tested ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants