UI: decode userdata in EditVM dialog#7796
Merged
DaanHoogland merged 1 commit intoapache:4.18from Aug 1, 2023
Merged
Conversation
Member
Author
|
@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Member
|
@harikrishna-patnala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
harikrishna-patnala
approved these changes
Aug 1, 2023
Member
harikrishna-patnala
left a comment
harikrishna-patnala
left a comment
There was a problem hiding this comment.
LGTM
Checked the usual userdata listing to see if there is an issue too, but no its working fine.
Codecov Report
@@ Coverage Diff @@
## 4.18 #7796 +/- ##
=========================================
Coverage 13.02% 13.02%
- Complexity 9030 9031 +1
=========================================
Files 2720 2720
Lines 257010 257010
Branches 40083 40083
=========================================
+ Hits 33463 33472 +9
+ Misses 219346 219336 -10
- Partials 4201 4202 +1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With PR #7749, we are able to update userdata with some characters (e.g. Chinese).
when edit the vm again, the userdata is not displayed correctly
with this PR, it works well
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?