vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier#3898
Conversation
|
@rhtyd @svenvogel @DennisKonrad |
|
@ustcweizhou does this require a new systemvmtemplate? Can you check the 4.14 systemvmtemplate (for haproxy etc) http://download.cloudstack.org/systemvm/4.14/ @blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
Outdated
Show resolved
Hide resolved
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
Outdated
Show resolved
Hide resolved
|
@ustcweizhou can you split the PR into two as there are changes that are solely around growing partition and root disk size change. |
|
@rhtyd sorry I uploaded wrong branch :-( |
3d04b4b to
ba5e034
Compare
… issues when add/remove vpc tier This fixes few issues below (1) when add/remove a vpc tier, the keepalived is restarted on both master and backup VRs, which causes some seconds donwtime of vpc. (2) when remove a vpc tier, the password server is not stopped. (3) vpc tier is shutdown because no vm is running for 20 minutes, if we start a vm in the vpc tier, it will be implemented. however the guest ip in VPC VRs will be changed , and password server is still running with old guest ip in VRs.
ba5e034 to
225eb0e
Compare
|
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-916 |
|
need to go in teh 4.13.1 milestone , @weizhouapache ? |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
@ustcweizhou can you check travis failure, see 1st job of travis -likely a python lint issue. |
|
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-965 |
|
@blueorangutan test |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
shwstppr
left a comment
There was a problem hiding this comment.
Code lgtm, manual testing needed
|
@andrijapanicsb @DaanHoogland manual testing needed here |
|
Trillian test result (tid-1147)
|
Description
This fixes few issues below
(1) when add/remove a vpc tier, the keepalived is restarted on both master and backup VRs, which causes some seconds donwtime of vpc.
(2) when remove a vpc tier, the password server is not stopped.
(3) vpc tier is shutdown because no vm is running for 20 minutes, if we start a vm in the vpc tier, it will be implemented. however the guest ip in VPC VRs will be changed , and password server is still running with old guest ip in VRs.
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?