Skip to content

vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier#3898

Merged
DaanHoogland merged 1 commit intoapache:4.13from
ustcweizhou:4.13-reload-keepalived-when-add-vpc-tier
Feb 28, 2020
Merged

vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier#3898
DaanHoogland merged 1 commit intoapache:4.13from
ustcweizhou:4.13-reload-keepalived-when-add-vpc-tier

Conversation

@ustcweizhou
Copy link
Copy Markdown
Contributor

Description

This fixes few issues below
(1) when add/remove a vpc tier, the keepalived is restarted on both master and backup VRs, which causes some seconds donwtime of vpc.
(2) when remove a vpc tier, the password server is not stopped.
(3) vpc tier is shutdown because no vm is running for 20 minutes, if we start a vm in the vpc tier, it will be implemented. however the guest ip in VPC VRs will be changed , and password server is still running with old guest ip in VRs.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

@ustcweizhou
Copy link
Copy Markdown
Contributor Author

@rhtyd @svenvogel @DennisKonrad
could you please test it if you use vpc ?

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Feb 20, 2020

@ustcweizhou does this require a new systemvmtemplate? Can you check the 4.14 systemvmtemplate (for haproxy etc) http://download.cloudstack.org/systemvm/4.14/

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Feb 20, 2020

@ustcweizhou can you split the PR into two as there are changes that are solely around growing partition and root disk size change.

@weizhouapache
Copy link
Copy Markdown
Member

@rhtyd sorry I uploaded wrong branch :-(

@ustcweizhou ustcweizhou force-pushed the 4.13-reload-keepalived-when-add-vpc-tier branch from 3d04b4b to ba5e034 Compare February 20, 2020 09:53
… issues when add/remove vpc tier

This fixes few issues below
(1) when add/remove a vpc tier, the keepalived is restarted on both master and backup VRs, which causes some seconds donwtime of vpc.
(2) when remove a vpc tier, the password server is not stopped.
(3) vpc tier is shutdown because no vm is running for 20 minutes, if we start a vm in the vpc tier, it will be implemented. however the guest ip in VPC VRs will be changed , and password server is still running with old guest ip in VRs.
@ustcweizhou ustcweizhou force-pushed the 4.13-reload-keepalived-when-add-vpc-tier branch from ba5e034 to 225eb0e Compare February 20, 2020 09:55
@weizhouapache weizhouapache changed the base branch from master to 4.13 February 20, 2020 09:55
@blueorangutan
Copy link
Copy Markdown

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-916

@DaanHoogland
Copy link
Copy Markdown
Contributor

need to go in teh 4.13.1 milestone , @weizhouapache ?

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Feb 28, 2020

@blueorangutan package

Copy link
Copy Markdown
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did not test it

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Feb 28, 2020

@ustcweizhou can you check travis failure, see 1st job of travis -likely a python lint issue.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-965

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Feb 28, 2020

@blueorangutan test

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Feb 28, 2020

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm, manual testing needed

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Feb 28, 2020

@andrijapanicsb @DaanHoogland manual testing needed here

@DaanHoogland DaanHoogland merged commit 3f8b2c3 into apache:4.13 Feb 28, 2020
DaanHoogland added a commit that referenced this pull request Feb 28, 2020
* 4.13:
  vrouter: reload keepalived instead of restart and fix password… (#3898)
  Allow port 80/8080 accessible only from guest network (#3907)
@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-1147)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28020 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3898-t1147-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_02_vpc_privategw_static_routes Failure 179.66 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 175.87 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Failure 250.59 test_privategw_acl.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants