vr: fix password server run with empty gateway in isolated network with RVRs

[ustcweizhou]

Description

This is regression issue of #3898

The password server in isolated network with RVRs run with wrong parameter

root@r-1083-VM:~# ps -ef|grep pass
root      1070     1  0 20:58 ?        00:00:01 python /opt/cloud/bin/passwd_server_ip.py ,192.168.10.84

it is because the gateway is "" for eth0 in /etc/cloudstack/ips.json.

This does not impact vpc with redundant VRs.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

restart network with cleanup, the new VR seems ok

root@r-1085-VM:~# ps -ef|grep pass
root      5468     1  0 21:37 ?        00:00:00 python /opt/cloud/bin/passwd_server_ip.py 192.168.0.1,192.168.0.28

How Has This Been Tested?

[ustcweizhou]

@rhtyd @DaanHoogland @andrijapanicsb sorry found a regression issue. please review.

[yadvr]

lgtm, did not test it

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1018

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[DaanHoogland]

makes sense, not tested, but will certainly improve quality

[blueorangutan]

Trillian test result (tid-1204)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28810 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3943-t1204-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_vpc_privategw_static_routes	Failure	188.87	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	Failure	179.20	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	Failure	237.15	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	Error	264.77	test_privategw_acl.py

[DaanHoogland]

@weizhouapache the private gateway errors have either not been fixed or have returned. Any resolution/opinion? cc @rhtyd

[weizhouapache]

@DaanHoogland the fix for private gateway issue is merged into master, not 4.13

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-1214)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26817 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3943-t1214-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_vpc_privategw_static_routes	Failure	174.65	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	Failure	175.00	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	Failure	226.93	test_privategw_acl.py

[DaanHoogland]

@DaanHoogland the fix for private gateway issue is merged into master, not 4.13

should those fixes be backported to 4.13?