ui: make vpc cidr required when not showing cidrsize

[shwstppr]

Description

Fixes #11391

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[shwstppr]

@blueorangutan ui

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build failed: ✖️
(SL-JID-718)

[shwstppr]

@blueorangutan ui

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.35%. Comparing base (8756be5) to head (178f3d3).
⚠️ Report is 35 commits behind head on 4.20.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #11393      +/-   ##
============================================
+ Coverage     16.16%   17.35%   +1.19%     
- Complexity    13279    15230    +1951     
============================================
  Files          5656     5885     +229     
  Lines        497884   525632   +27748     
  Branches      60378    64162    +3784     
============================================
+ Hits          80463    91225   +10762     
- Misses       408466   424110   +15644     
- Partials       8955    10297    +1342     

Flag	Coverage Δ
uitests	3.63% <ø> (-0.38%)	⬇️
unittests	18.39% <ø> (+1.38%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11393 (QA-JID-719)

[weizhouapache]

code lgtm

thanks @shwstppr for the fix

[DaanHoogland]

code looks good and tested, but in this case could we have the place holder or the tooltip display a default cidr or a description of possible formats? If I enter only “10” it is accepted by the UI but not by the service layer.

[sureshanaparti]

@shwstppr can rebase this with 4.20 (the issue raised for 4.20.1)?

[shwstppr]

@sureshanaparti I'm okay with it being added in main

[DaanHoogland]

code looks good and tested, but in this case could we have the place holder or the tooltip display a default cidr or a description of possible formats? If I enter only “10” it is accepted by the UI but not by the service layer.

@shwstppr , should we create a new issue for this?

[shwstppr]

@sureshanaparti I've changed the base branch
@DaanHoogland will check but I guess a separate issue with or without this change

@blueorangutan ui

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11393 (QA-JID-721)

[RosiKyu]

LGTM - tested and verified the fix