feat(desktop): add Rename Session menu shortcut#15567
Open
anduimagui wants to merge 4 commits intoanomalyco:devfrom
Open
feat(desktop): add Rename Session menu shortcut#15567anduimagui wants to merge 4 commits intoanomalyco:devfrom
anduimagui wants to merge 4 commits intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #1389
Type of change
What does this PR do?
Adds desktop support for renaming sessions via menu shortcut.
File > Rename Session...inpackages/desktop/src/menu.tsShift+Cmd+Eon macOSsession.renamethrough desktop command wiringdesktop.menu.file.renameSessioninpackages/desktop/src/i18n/en.tsOn current
dev,session.renamewas not registered yet. This PR includes minimal app command registration inpackages/app/src/pages/session/message-timeline.tsxand reuses the existing inline title editor.Related:
How did you verify your code works?
File > Rename Session...appearsShift+Cmd+Etriggers session title rename flowScreenshots / recordings
Checklist
If you do not follow this template your PR will be automatically rejected.