-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Closed
Labels
needs:complianceThis means the issue will auto-close after 2 hours.This means the issue will auto-close after 2 hours.webRelates to opencode on web / desktopRelates to opencode on web / desktop
Description
Heads up from #15567: we registered session.rename in packages/app/src/pages/session/message-timeline.tsx to keep that PR scoped and unblock desktop menu wiring quickly.
Would be nice to do a small follow-up to move that command registration into packages/app/src/pages/session/use-session-commands.tsx (where the other session command IDs already live), so command discovery/ownership is in one place.
Current state from #15567:
- Desktop menu now triggers
session.rename - App command exists, but it’s registered in the timeline component because that file owns
openTitleEditor+ title edit state
Follow-up idea:
- Keep rename UI state where it belongs
- Pass a rename action callback (or lift a small bit of state) so
use-session-commands.tsxcan own thesession.renameregistration
Not urgent, just cleanup for consistency and maintainability.
Refs:
- PR: feat(desktop): add Rename Session menu shortcut #15567
- Current command registration location:
packages/app/src/pages/session/message-timeline.tsx - Preferred command registration location:
packages/app/src/pages/session/use-session-commands.tsx
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
needs:complianceThis means the issue will auto-close after 2 hours.This means the issue will auto-close after 2 hours.webRelates to opencode on web / desktopRelates to opencode on web / desktop