feat: Broaden Score Calibration Permissions Create/Update#666
Open
bencap wants to merge 5 commits intochore/bencap/agent-md-improvementsfrom
Open
feat: Broaden Score Calibration Permissions Create/Update#666bencap wants to merge 5 commits intochore/bencap/agent-md-improvementsfrom
bencap wants to merge 5 commits intochore/bencap/agent-md-improvementsfrom
Conversation
…nt endpoints
Score set API responses were slow (5+ seconds) because functional
classifications eagerly serialized thousands of variants. This moves
variant data to dedicated endpoints while keeping a lightweight
variant_count summary in the default response.
Changes:
- Remove `variants` field from functional classification view models
- Add `id` and `variant_count` fields to SavedFunctionalClassification
- Add `variant_count` column_property on the ORM model using a
correlated COUNT subquery against the association table
- Add `FunctionalClassificationVariants` response model
- Add GET /{urn}/functional-classifications/{id}/variants endpoint
- Add GET /{urn}/variants endpoint (all classifications)
- Update test constants and assertions for new response shape
Breaking change: clients relying on `variants` in calibration responses
must migrate to the new dedicated endpoints.
691d2ba to
7d60adc
Compare
7d60adc to
a96cab7
Compare
…ion models and related logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces new permissions and API endpoints for handling score calibrations in the MaveDB codebase. The main changes include adding a new
ADD_CALIBRATIONaction, updating permission logic to allow broader access to calibration uploads, and requiring users to have email addresses for calibration operations.Permissions and Access Control
ADD_CALIBRATIONaction in theActionenum and updated permission checks so any authenticated user can add calibrations to published score sets, while private score sets require owner/contributor/admin access. [1] [2] [3] [4]ADD_CALIBRATIONpermission instead ofUPDATE, and clarified requirements to include having an email address. [1] [2] [3] [4] [5] [6]require_current_user_with_email, ensuring users have verified email addresses for these actions. [1] [2] [3] [4] [5] [6] [7]Permission Logic Adjustments
Minor Fixes and Refactoring