feat: UI Support for Community Calibration Permission Broadening#625
Open
bencap wants to merge 2 commits intofeature/bencap/calibration-performance-improvementsfrom
Conversation
Allow any authenticated user to create calibrations on published score sets (community calibrations), not just score set contributors/owners. - Use backend's `add_calibration` permission action instead of deriving calibration access from the `update` permission - Add EmailPrompt gate to calibration creation/edit dialogs so users without an email are prompted before proceeding - Make EmailPrompt modal with z-index above calibration dialogs for proper stacking - Handle 403 email-related errors on calibration save with descriptive toast messages - Remove redundant `userIsAuthorizedToEditScoreSet` check on calibration edit button (backend handles this via per-calibration permissions) - Rename `classificationSources` to `evidenceSources` across all components and schema types to match backend API rename
…tion types and sources
Collaborator
Author
|
UI support for VariantEffect/mavedb-api#666 |
bencap
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements several improvements and refactors related to calibration management and evidence source handling in the application. The main changes include renaming the "classificationSources" field to "evidenceSources" throughout the codebase, improving authorization logic for adding calibrations, and enhancing user experience by prompting users to add an email address when required. Additionally, the pull request introduces UI and error handling enhancements for calibration-related actions.
Calibration Source Renaming and Refactor:
classificationSourcestoevidenceSourcesin components such asCalibrationEditor.vue,CalibrationTable.vue, andAssayFactSheet.vue, including data models, props, computed properties, and template bindings. This ensures consistency in terminology and improves clarity in the codebase. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Authorization and Permission Improvements:
add_calibrationpermission rather than relying onupdate, both in the backend API calls and in UI logic, to more accurately reflect user capabilities for adding calibrations. [1] [2] [3] [4]Email Prompt and Error Handling Enhancements:
EmailPromptcomponent to calibration-related views (ScoreSetCalibrationsView.vueandScoreSetView.vue), prompting users to add an email address if required before creating or editing calibrations. [1] [2] [3] [4] [5] [6]UI and Usability Improvements:
Dialog and Modal Improvements:
EmailPromptdialog to use a higher z-index and modal behavior for better visibility and focus when prompting users.