Skip to content

implemented timer #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kr1s-r merged 6 commits into from
Jun 14, 2025
Merged

implemented timer #197

kr1s-r merged 6 commits into from
Jun 14, 2025

Conversation

@kr1s-r
Copy link
Member

@kr1s-r kr1s-r commented Feb 15, 2025

No description provided.

@kr1s-r kr1s-r requested a review from a team as a code owner February 15, 2025 20:19
@vercel
Copy link

vercel bot commented Feb 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helios-telemetry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2025 8:57pm

@justin-phxm
Copy link
Collaborator

justin-phxm commented Feb 23, 2025

What does this PR do

@burtonjong
Copy link
Member

burtonjong commented Feb 23, 2025

What does this PR do

@justin-phxm its for the time left and laps completed under the map

burtonjong
burtonjong requested changes Feb 27, 2025
View reviewed changes
@kr1s-r kr1s-r force-pushed the TEL-230-connect-laps-left-and-time-left-to-actual-values branch from 8dc6fd9 to 00e432a Compare February 27, 2025 22:48
@kr1s-r kr1s-r requested a review from burtonjong March 1, 2025 17:52
@justin-phxm
Copy link
Collaborator

justin-phxm commented Mar 1, 2025

image

justin-phxm
justin-phxm requested changes Mar 1, 2025
View reviewed changes
Copy link
Collaborator

@justin-phxm justin-phxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I'm not a big fan of leaving lapsLeft to 100... We should change it to lapsCompleted instead. FSGP scores based on how many laps you complete, not aiming to achieve a certain number of laps.

@kr1s-r kr1s-r force-pushed the TEL-230-connect-laps-left-and-time-left-to-actual-values branch from 00e432a to f184b5a Compare March 6, 2025 03:56
justin-phxm
justin-phxm requested changes Mar 8, 2025
View reviewed changes
@kr1s-r kr1s-r requested a review from justin-phxm March 8, 2025 21:41
@burtonjong burtonjong force-pushed the main branch 3 times, most recently from 49e1bfd to 2622e7a Compare March 15, 2025 19:20
justin-phxm
justin-phxm requested changes Mar 15, 2025
View reviewed changes
Copy link
Collaborator

@justin-phxm justin-phxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data consistency is a hard topic in software development. Let me know if you have any questions.

packages/server/src/controllers/LapController/LapController.ts Outdated
// }
const checkDebounce = this.checkDebounce(packet);

if (
Copy link
Collaborator

@justin-phxm justin-phxm Mar 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

if(checkDebounce(packet)){
...
}

move the conditionally checking logic into checkDebounce()

Copy link
Member Author

@kr1s-r kr1s-r Mar 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure, this if statement is also based on inProximity which is in checkLap() function

@kr1s-r kr1s-r requested a review from justin-phxm March 30, 2025 02:38
@kr1s-r
Copy link
Member Author

kr1s-r commented Mar 30, 2025

Might still need to fix resetting lap time based on the times we are racing on (hopefully RaceMode will be accurate). Can add a total distance counter and a total lap counter for each race day.

justin-phxm
justin-phxm requested changes Apr 3, 2025
View reviewed changes
Copy link
Collaborator

@justin-phxm justin-phxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets call once you address these changes so I can see the demo with your commentary.

justin-phxm
justin-phxm requested changes Apr 19, 2025
View reviewed changes
@kr1s-r
Copy link
Member Author

kr1s-r commented May 3, 2025 •
edited
Loading

Before we can check lap counter and debounce feature, we might need radius around finish line (from here: #218)

@kr1s-r kr1s-r force-pushed the TEL-230-connect-laps-left-and-time-left-to-actual-values branch from fa24b5c to b758c56 Compare May 3, 2025 21:36
@kr1s-r kr1s-r requested a review from justin-phxm May 3, 2025 23:17
justin-phxm
justin-phxm requested changes May 9, 2025
View reviewed changes
Copy link
Collaborator

@justin-phxm justin-phxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
I don't like this Nan

@kr1s-r kr1s-r force-pushed the TEL-230-connect-laps-left-and-time-left-to-actual-values branch from b758c56 to ffc5a24 Compare May 10, 2025 21:19
@kr1s-r kr1s-r requested a review from justin-phxm May 10, 2025 21:20
@kr1s-r kr1s-r force-pushed the TEL-230-connect-laps-left-and-time-left-to-actual-values branch from ffc5a24 to 55e9892 Compare May 17, 2025 20:01
@kr1s-r kr1s-r force-pushed the TEL-230-connect-laps-left-and-time-left-to-actual-values branch from 55e9892 to 10b8db2 Compare May 17, 2025 20:09
@kr1s-r kr1s-r force-pushed the TEL-230-connect-laps-left-and-time-left-to-actual-values branch from 10b8db2 to 30532bb Compare May 17, 2025 21:54
@kr1s-r kr1s-r force-pushed the TEL-230-connect-laps-left-and-time-left-to-actual-values branch from 30532bb to 7f543b9 Compare June 14, 2025 20:53
@burtonjong burtonjong mentioned this pull request Jun 14, 2025
Merged
@kr1s-r kr1s-r merged commit 7d3b78d into main Jun 14, 2025
6 checks passed
@kr1s-r kr1s-r deleted the TEL-230-connect-laps-left-and-time-left-to-actual-values branch June 14, 2025 21:47
burtonjong added a commit that referenced this pull request Jun 21, 2025
@burtonjong
Revert "implemented timer (#197)"
51b78c1 
This reverts commit 7d3b78d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@burtonjong burtonjong burtonjong approved these changes

@justin-phxm justin-phxm justin-phxm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kr1s-r @justin-phxm @burtonjong