Skip to content

refactor darkmode to use next-themes #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skand088 merged 20 commits into from
Aug 4, 2025
Merged

refactor darkmode to use next-themes #239

skand088 merged 20 commits into from
Aug 4, 2025

Conversation

@skand088
Copy link
Contributor

@skand088 skand088 commented May 24, 2025

can refactor further to use custom css variables and avoid dark: prefixes and long tailwind styles

@skand088 skand088 requested a review from a team as a code owner May 24, 2025 19:22
@vercel
Copy link

vercel bot commented May 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helios-telemetry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2025 10:18pm

@skand088 skand088 force-pushed the TEL-264-make-dark-mode-based-on-system-not-default-to-light branch from 3f4e3b8 to 22bca75 Compare May 24, 2025 20:21
@skand088 skand088 requested a review from burtonjong May 31, 2025 18:27
burtonjong
burtonjong requested changes May 31, 2025
View reviewed changes
Copy link
Member

@burtonjong burtonjong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove changes here

@burtonjong
Copy link
Member

burtonjong commented May 31, 2025

image

icons should be white on dark mode

@burtonjong
Copy link
Member

burtonjong commented May 31, 2025

image

opening settings should be a darker color as well please save this as a resuable color whatever you decide though

@burtonjong
Copy link
Member

burtonjong commented May 31, 2025

image

can this dotted container be a gray

@burtonjong
Tel 257 fix hover animations on laps table (#237)
0869c87 
* edit docs, refactor race tab

* done

* fix

* remove package

* readd dark mode styles
@skand088 skand088 force-pushed the TEL-264-make-dark-mode-based-on-system-not-default-to-light branch from ea19bb6 to 2fdcda0 Compare June 7, 2025 17:08
@skand088 skand088 requested a review from burtonjong June 7, 2025 17:14
@burtonjong
Copy link
Member

burtonjong commented Jun 7, 2025

borders should be white

image

map should have a dark mode
image

even when no faults scrollbar gutter shows still, also the white border a lil too much maybe we can make it grayish
image

@skand088 skand088 requested review from burtonjong and promatty July 26, 2025 16:37
alexwhelan12
alexwhelan12 previously approved these changes Jul 26, 2025
View reviewed changes
Copy link
Contributor

@alexwhelan12 alexwhelan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

promatty
promatty requested changes Jul 26, 2025
View reviewed changes
Copy link
Member

@promatty promatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chat why is system dark mode missing those changes from normal dark mode

Screen.Recording.2025-07-26.at.11.18.53.AM.mov

promatty
promatty requested changes Jul 26, 2025
View reviewed changes
Copy link
Member

@promatty promatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue with optimal driving speed within stats not showing the bar in darkmode is still there 🥲

my review from june 14th:

-the "graphs" and "stats" words are supposed to be white in darkmode

Screenshot 2025-06-14 at 10 28 12 AM -optimal driving speed within stats does not show the bar in darkmode Screenshot 2025-06-14 at 10 28 15 AM -also, is next-themes supposed to reduce the dark: and light: prefixes? if so, do that. -custom tailwind vars pls :)

alexwhelan12
alexwhelan12 previously approved these changes Jul 26, 2025
View reviewed changes
Copy link
Contributor

@alexwhelan12 alexwhelan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

promatty
promatty reviewed Aug 2, 2025
View reviewed changes
promatty
promatty approved these changes Aug 3, 2025
View reviewed changes
Copy link
Member

@promatty promatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

be free ✨

@skand088 skand088 requested a review from alexwhelan12 August 4, 2025 02:27
@skand088 skand088 merged commit ed8a833 into main Aug 4, 2025
6 checks passed
@skand088 skand088 deleted the TEL-264-make-dark-mode-based-on-system-not-default-to-light branch August 4, 2025 02:45
@skand088
Copy link
Contributor Author

skand088 commented Aug 4, 2025

WOOOHOOOO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@promatty promatty promatty approved these changes

@burtonjong burtonjong burtonjong approved these changes

@alexwhelan12 alexwhelan12 Awaiting requested review from alexwhelan12

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skand088 @burtonjong @promatty @alexwhelan12