Skip to content

Add IdentifyGooglePlayGames API#184

Open
tudddorrr wants to merge 1 commit intodevelopfrom
gpg-integration
Open

Add IdentifyGooglePlayGames API#184
tudddorrr wants to merge 1 commit intodevelopfrom
gpg-integration

Conversation

@tudddorrr
Copy link
Contributor

No description provided.

@tudddorrr tudddorrr added the enhancement New feature or request label Mar 17, 2026
@claude
Copy link

claude bot commented Mar 17, 2026

PR Review: Add IdentifyGooglePlayGames API


Major: Missing identity parameter for account linking

IdentifySteam supports an optional identity parameter for account linking but IdentifyGooglePlayGames does not:

IdentifySteam signature:
public async Task IdentifySteam(string ticket, string identity = "")

IdentifyGooglePlayGames signature (new):
public async Task IdentifyGooglePlayGames(string authCode)

If account linking needs to be supported for Google Play Games later, adding identity would be a breaking change. Adding it now as an optional parameter costs nothing and keeps the API surface consistent:

public async Task IdentifyGooglePlayGames(string authCode, string identity = "")
{
if (string.IsNullOrEmpty(identity))
{
await Identify("google_play_games", authCode);
}
else
{
await Identify("google_play_games", identity + ":" + authCode);
}
return Talo.CurrentPlayer;
}


No other issues found. The implementation is clean and consistent with the existing pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant