Skip to content

Conversation

@shahdyousefak
Copy link
Contributor

Please ensure you've followed the checklist and provide all the required information before requesting a review.
If you do not have everything applicable to your PR, it will not be reviewed!
If you don't know what something is or if it applies to you, ask!

Don't delete below this line.


Required Information

  • I referenced the issue addressed in this PR. --> resolves Deprecate unused preprocessors #1006.
  • I described the changes made and how these address the issue. --> moved respective components to deprecated dirs, removed entries + dependencies from docker/test docker composes
  • I described how I tested these changes. --> tested on unicorn, requests succeeded ad returned renderings

Coding/Commit Requirements

  • I followed applicable coding standards where appropriate (e.g., PEP8)
  • I have not committed any models or other large files.

New Component Checklist (mandatory for new microservices)

  • I added an entry to docker-compose.yml and build.yml. --> removed entries
  • I created A CI workflow under .github/workflows.
  • I have created a README.md file that describes what the component does and what it depends on (other microservices, ML models, etc.).

OR

  • I have not added a new component in this PR.

@shahdyousefak shahdyousefak requested a review from jeffbl June 3, 2025 18:29
@shahdyousefak shahdyousefak linked an issue Jun 3, 2025 that may be closed by this pull request
Copy link
Member

@jeffbl jeffbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably not leave traces around for archiving stuff, and trust that we can go back in git history if we ever need it again. Otherwise looks good.

@@ -1,17 +1,20 @@
name: Action Recognition
# Disabled workflow — kept for archival purposes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is all in git, so should we really keep this, or will it just be confusing?

Copy link
Contributor Author

@shahdyousefak shahdyousefak Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, removing comment

@jeffbl jeffbl removed their assignment Jun 5, 2025
@shahdyousefak shahdyousefak merged commit 1483f80 into main Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate unused preprocessors

4 participants