Skip to content

fix: allow passing gainPI__k to PI component #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AayushSabharwal wants to merge 1 commit into from
+4 −3
Closed

fix: allow passing gainPI__k to PI component #437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Blocks/continuous.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,19 +241,20 @@ U(s) = k (1 + \\dfrac{1}{sT}) E(S)

See also [`LimPI`](@ref)
"""
@component function PI(; name, k = 1.0, T = 1.0)
@component function PI(; name, k = 1.0, T = 1.0, gainPI__k = nothing)
Copy link
Contributor

@baggepinnen baggepinnen Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed?

Copy link
Member Author

@AayushSabharwal AayushSabharwal Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used by a test in MTK's downstream

Copy link
Contributor

@baggepinnen baggepinnen Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't that test be updated instead?

Copy link
Member Author

@AayushSabharwal AayushSabharwal Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try. I'm not entirely sure why it needs to pass k down to a subcomponent, I just saw the stacktrace and made the PR 😅 .

@symcheck T > 0 ||
throw(ArgumentError("Time constant `T` has to be strictly positive"))

pars = @parameters begin
k = k, [description = "Proportional gain"]
T = T, [description = "Integrator time constant"]
end


gainPI__k = @something(gainPI__k, k)
systems = @named begin
err_input = RealInput() # control error
ctr_output = RealOutput() # control signal
gainPI = Gain(; k)
gainPI = Gain(; k = gainPI__k)
addPI = Add()
int = Integrator(k = 1 / T, x = 0.0)
end
Expand Down
Loading