fix: allow passing gainPI__k to PI component#437
Closed
AayushSabharwal wants to merge 1 commit intomainfrom
Closed
fix: allow passing gainPI__k to PI component#437AayushSabharwal wants to merge 1 commit intomainfrom
gainPI__k to PI component#437AayushSabharwal wants to merge 1 commit intomainfrom
Conversation
baggepinnen
reviewed
Jan 27, 2026
| See also [`LimPI`](@ref) | ||
| """ | ||
| @component function PI(; name, k = 1.0, T = 1.0) | ||
| @component function PI(; name, k = 1.0, T = 1.0, gainPI__k = nothing) |
Member
Author
There was a problem hiding this comment.
It's used by a test in MTK's downstream
Contributor
There was a problem hiding this comment.
shouldn't that test be updated instead?
Member
Author
There was a problem hiding this comment.
I can try. I'm not entirely sure why it needs to pass k down to a subcomponent, I just saw the stacktrace and made the PR 😅 .
Member
Author
|
This is not necessary anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.