Skip to content

feature/137-checkout-minicart-sticky #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Puneetsehgal wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

feature/137-checkout-minicart-sticky #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65c221e
feature/137-checkout-minicart-sticky
Puneetsehgal Mar 10, 2020
4aff0d6
feature/137-checkout-minicart-sticky tech review change, change the c…
Puneetsehgal Mar 10, 2020
4cf13b9
feature/137-checkout-minicart-sticky tech review changes removed unwa…
Puneetsehgal Mar 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/order-summary/order-summary.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="order-summary" data-js="order-summary">
<div class="order-summary order-summary--sticky-minicart" data-js="order-summary">
<div class="order-summary__background">
<h2 class="order-summary__title">Order Summary</h2>

Expand Down
5 changes: 5 additions & 0 deletions src/pages/checkout/checkout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,7 @@ const populateFields = () => {
}
};


window.onload = () => {
//signInForm = document.querySelector('.checkout__sign-in-form');
mainForm = document.querySelector('.checkout__main-form');
Expand Down Expand Up @@ -349,6 +350,10 @@ window.onload = () => {
populateFields();
}

// set the height for the sticky mini cart container
let stickyMiniCartContainer = document.querySelector(".order-summary--sticky-minicart");
stickyMiniCartContainer.style.height = stickyMiniCartContainer.querySelector(".order-summary__background").clientHeight + "px";

Modal.init('construction-modal');
};

Expand Down
12 changes: 10 additions & 2 deletions src/pages/checkout/checkout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,8 @@
.checkout {
margin-bottom: 80px;
padding: 0;

display: grid;
@media only screen and (min-width: $filters-collapse) {
display: grid;
grid-template-columns: 60% 35%;
grid-gap: 5%;
}
Expand Down Expand Up @@ -502,10 +501,19 @@
margin-top: 50px;
padding: 0 8px;

@media screen and (max-width: $mobile) {
grid-row-start: 1;
}

@media only screen and (min-width: $filters-collapse) {
grid-column: 2 / 2;
margin-top: 66px;
padding: 0;
&--sticky-minicart {
position: sticky;
top: 0;
z-index: 10;
}
}

&__image {
Expand Down