feature/137-checkout-minicart-sticky #271
Conversation
Made Checkout Mini cart sticky for Desktop and Tablet and chnage the order of section in mobile, Move the mini cart above the address and credit card form
| @@ -1,4 +1,4 @@ | |||
| <div class="order-summary" data-js="order-summary"> | |||
| <div class="order-summary sticky-moneybox" data-js="order-summary"> | |||
There was a problem hiding this comment.
I would suggest to change sticky-moneybox class name to be more BEM (since it is a modifier). i.e. order-summary--sticky-moneybox. You'll need to have that class in addition to the original order-summary. i.e.:
<div class="order-summary order-summary--sticky-moneybox" data-js="order-summary">
There was a problem hiding this comment.
Yeah, make sense. I will make the change
src/pages/checkout/checkout.js
Outdated
| } | ||
| }; | ||
|
|
||
| const stickyMoneybox = () => { |
There was a problem hiding this comment.
It isn't immediately clear, from the function name, what this does. It doesn't seem to be a pure function (since it doesn't return anything, and it seems to manipulate something outside of itself). Is it only run once? Perhaps it shouldn't be a function then?
There was a problem hiding this comment.
Made the changes
Made Checkout Mini cart sticky for Desktop and Tablet and chnage the order of section in mobile, Move the mini cart above the address and credit card form