Skip to content

Conversation

@Space646
Copy link
Contributor

Description

Changed 'Hair drier' --> 'Hair dryer'

Meta

Merge checklist:

  • [*] Pull Request title is short, imperative summary of proposed changes
  • [*] The description documents the what and why
  • [*] If this PR changes behavior or adds a feature, user documentation is updated
  • [*] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • [*] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • [*] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • [*] If this PR addresses a bug, a regression test for it is added

@Space646 Space646 requested a review from a team as a code owner December 18, 2025 07:44
@github-actions github-actions bot added the backend Things relating to photon-core and photon-server label Dec 18, 2025
@Gold856
Copy link
Collaborator

Gold856 commented Dec 18, 2025

This is actually how it's spelled in the original COCO dataset (https://arxiv.org/pdf/1405.0312, page 14). I don't really want to diverge from that, so I think we should keep the original spelling. Perhaps a note that this is the original spelling is warranted?

@samfreund
Copy link
Member

[*] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes [*] The description documents the what and why [*] If this PR changes behavior or adds a feature, user documentation is updated [*] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly [*] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2 [*] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated [*] If this PR addresses a bug, a regression test for it is added

just some advice for the future, if you leave this blank github will make checkboxes. alternately, you can fill them by doing - [x] like so

  • stuff here

@Space646
Copy link
Contributor Author

Oops, sorry.
Weird that it's spelled that way, but I guess as long as it works it's fine.

I changed it back to how it was previously and added a comment as @Gold856 suggested.

@samfreund
Copy link
Member

Space646 and others added 3 commits January 18, 2026 23:54
Changed back from 'hair dryer' to 'hair dryer', just like in the official COCO documentation. Added comment about it.
Signed-off-by: Jade Turner <[email protected]>
@spacey-sooty spacey-sooty changed the title Fix typo in NeuralNetworkModelManager Add comment documenting typo copied from COCO docs Jan 18, 2026
@spacey-sooty spacey-sooty merged commit bc208bc into PhotonVision:main Jan 18, 2026
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants