feat: Add driver for ADS7128 ADC#26471
Open
Phil-Engljaehringer wants to merge 3 commits intoPX4:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new PX4 driver module for the ADS7128 12-bit, 8-channel I2C ADC and exposes configuration via parameters.
Changes:
- Introduces new ADS7128 driver (I2C, scheduled polling, uORB
adc_reportpublication) - Adds module build/config plumbing (CMake, Kconfig, module.yaml parameters)
- Registers a new device type ID for ADS7128
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/drivers/drv_sensor.h | Adds ADS7128 ADC device type ID for bus enumeration |
| src/drivers/adc/ads7128/module.yaml | Defines ADS7128 enable + reference voltage parameters |
| src/drivers/adc/ads7128/ads7128_main.cpp | Adds module entrypoint/CLI handling for the driver |
| src/drivers/adc/ads7128/ads7128.h | Declares ADS7128 driver class, state machine, params, uORB pub |
| src/drivers/adc/ads7128/ads7128.cpp | Implements I2C transactions, configuration, sampling, publishing |
| src/drivers/adc/ads7128/Kconfig | Adds Kconfig option to enable the driver |
| src/drivers/adc/ads7128/CMakeLists.txt | Adds build definition for the new driver module |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved Problem
We needed a driver for the ADS7128 analog-digital-converter
Solution
Implemented new driver for ADS7128 12-bit 8-channel I2C ADC
Changelog Entry
For release notes:
Test coverage
Benchtest on my desk